V2.1 comp mode behavior should be fixed for diff of v2 and v2.1 APIs

[Ghanshyam Mann]

There are some cases where v2.1 is different than v2.0 -
- VIF API - no net-id in v2.1
- rate limit bits - not present in v2.1
- extension info - namespace diff

For above cases, current v2.1 compatible mode behaves same as v2.1 not v2.
Failure in - http://logs.openstack.org/86/224386/1/check/gate-nova-tox-functional/b98e535/testr_results.html.gz

As v2.1 comp mode should behave same as v2 instead of v2.1, we should fix those cases to return same response as v2 APIs does.

I am not sure about rate limit and extension info things, should we fix those?

It was found when we start running v2.1 comp mode sample test against v2 sample files instead of v2.1 one. - https://review.openstack.org/#/c/224386/

[Alex Xu (xuhj)]

For ratelimit, if user add the Ratelimit Middleware back, then the rate limits bits in the API will works, so we can fix it by add to api-paste.ini

For extension info, I think it's fine, the namespace is just for XML I think, so actually it is useless thing.

For VIF API, it is hard one. As we already remove the extension info API entry for extend-vif-net, so at least that won't break the user.
And we decided we add those extend vif net atributes back with Microversions, and we already did that https://review.openstack.org/#/c/198944/ . So fix it in v2.1 isn't option, but we can fix it in v2.1 compat mode only.

[Ghanshyam Mann (ghanshyammann)]

>For extension info, I think it's fine, the namespace is just for XML I think, so actually it is useless thing.

Yea i also think that should be fine.

But I think we need to return VIF extension (which has been removd from v2.1 ext list) for v21 comp mode.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/224450

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/224453

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ghanshyam Mann (<email address hidden>) on branch: master
Review: https://review.openstack.org/224453
Reason: Merged in https://review.openstack.org/#/c/224450/1

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/224450
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9a7b9e6214eb7169941e16b28dcb1fb9c21f3f12
Submitter: Jenkins
Branch: master

commit 9a7b9e6214eb7169941e16b28dcb1fb9c21f3f12
Author: ghanshyam <email address hidden>
Date: Thu Sep 17 15:07:21 2015 +0900

    Add 'OS-EXT-VIF-NET:net_id' for v21 compatible mode

    There is difference in VIF list response for v2 and v2.1.
    'net_id' attribute is not present in v2.1 VIF list response and
    it was added as new microversion - Ic8b26df8d7e69bd71d23dfbc983fa3449c16fa7d

    For v21 compatible mode we should have that attribute in response
    to make v21 comp mode behaves same as v2.

    Also VIF Extension "OS-EXT-VIF-NET" was removed from v2.1 ext list
    in - Ic99ac1179d02d907422911fe1369b64479fd5f33

    As we need to add 'OS-EXT-VIF-NET:net_id' in VIF
    API response to make that same as v2 one. So ext list should have
    "OS-EXT-VIF-NET" extension also to avoid any confusion for user whether
    this extension is present for v21 comp mode or not.

    This commit adds 'OS-EXT-VIF-NET:net_id' attribute in VIF list
    response for v21 compatible mode.
    Also adds VIF extension in ext list for v21 comp mode.

    NOTE-There is no change in v2.1 API.

    Closes-Bug #1496664

    Change-Id: I4df76fbf85fbb1e79528a1690692b12a65f07835

[Matt Riedemann (mriedem)]

API docs fix: https://review.openstack.org/#/c/288960/

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/288962

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/288960
Committed: https://git.openstack.org/cgit/openstack/api-site/commit/?id=96c0a3e8382017f168d61b72cf3c4ff8279693e6
Submitter: Jenkins
Branch: master

commit 96c0a3e8382017f168d61b72cf3c4ff8279693e6
Author: Matt Riedemann <email address hidden>
Date: Sat Mar 5 21:03:15 2016 -0500

    Compute: doc v2.12 microversion in os-virtual-interfaces

    Nova commit 45d1e3c1fa8f7921aeb1b04a2452ae10ccc6aa06 added
    the net_id attribute back to the os-virtual-interfaces response
    with the v2.12 microversion.

    Change-Id: Ibe7c0f99467e0a4b852348418a0e2e84afdc3a65
    Closes-Bug: #1496664

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/288962
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a9a0d646cffafb01412cc65f67fa2efe48d980ce
Submitter: Jenkins
Branch: master

commit a9a0d646cffafb01412cc65f67fa2efe48d980ce
Author: Matt Riedemann <email address hidden>
Date: Sat Mar 5 21:15:20 2016 -0500

    Fix v2.12 microversion REST API history doc

    The attribute returned in the response body is 'net_id', not
    'net-id'. We should be accurate in our REST API docs.

    Change-Id: I4d6a8084fd73777a7dc5ebd58a462ada0627daf4
    Related-Bug: #1496664