When post an unkown external event to nova api, it will return 500

[Alex Xu]

The InstanceExternalEvent object use enum type for name field https://github.com/openstack/nova/blob/279c2b0a015b67c5195ab028eeab15b00a94e5ee/nova/objects/external_event.py#L41

But there isn't any limit in the API schema https://github.com/openstack/nova/blob/279c2b0a015b67c5195ab028eeab15b00a94e5ee/nova/api/openstack/compute/schemas/server_external_events.py#L29

It leads to return 500.

[Alex Xu (xuhj)]

The enum type added after Kilo release https://review.openstack.org/#/c/183131/

That means the v2.1 API already released. But due to this API is only used by sending event between openstack services. I think it's ok fix this in v2.1 API directly without microverions

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/222033

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/222033
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4027bbecdd8cbaf85bb48f750401df33b7ba40af
Submitter: Jenkins
Branch: master

commit 4027bbecdd8cbaf85bb48f750401df33b7ba40af
Author: He Jie Xu <email address hidden>
Date: Thu Sep 10 13:30:39 2015 +0800

    Check unknown event name when create external server event

    The InstanceExternalEvent use enum type for name field, but nova api
    didn't validate the name field, it leads to return 500 when unknown
    event recived.

    InstanceExternalEvent's name field turn to enum type in patch
    https://review.openstack.org/#/c/183131, although it merged after
    v2.1 API release, but this API is only used by openstack services.
    So it's ok for fixing this without Microversions

    Change-Id: I38a6e26d5b66d67645be50c1a907489c8a2d40fe
    Closes-Bug: #1494125