missing logging variable in nova network manager deallocate_fixed_ip

[Matt Riedemann]

Seen here:

http://logs.openstack.org/96/219696/4/check/gate-tempest-dsvm-large-ops/158f061/logs/screen-n-net.txt.gz#_2015-09-03_15_11_10_664

2015-09-03 15:11:10.664 DEBUG nova.network.manager [req-ae96c425-a199-472f-a0db-e1b48147bb4c tempest-TestLargeOpsScenario-1690771764 tempest-TestLargeOpsScenario-1474206998] [instance: 195361d7-95c3-4740-825b-1acab707969e] Explicitly disassociating fixed IP %s from instance. deallocate_fixed_ip /opt/stack/new/nova/nova/network/manager.py:1077

Added here:

https://github.com/openstack/nova/commit/b536ff12ae92e728033cb81eeba9a03fd1c81a41

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/220253

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/220253
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=334ffef872f439e7a31ff33ffed250701cc56d3e
Submitter: Jenkins
Branch: master

commit 334ffef872f439e7a31ff33ffed250701cc56d3e
Author: Matt Riedemann <email address hidden>
Date: Thu Sep 3 10:34:17 2015 -0700

    nova-net: fix missing log variable in deallocate_fixed_ip

    Introduced in b536ff12ae92e728033cb81eeba9a03fd1c81a41, just need to add
    the fixed IP for the log message variable substitution.

    Adds a test to make sure FixedIP.disassociate() is actually called in
    this case - I didn't see any existing tests for that condition.

    Closes-Bug: #1491951

    Change-Id: Ie4dc424fbc6fc3ef6aa58a5030fd3e8ed96da56c

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/221973

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/221973
Reason: I'm going to throw this fish back, since I never really caught it anyway.