Lack of volume status checks when detaching volume in rebuild.

[Zhenyu Zheng]

Currently, when rebuilding an instance with volume attached, the Nova compute manager will directly call _detach_volume() which will skip the checks of volume status (volume_api.check_detach) and setting the volume to 'detaching' (volume_api.begin_detaching) at Cinder side. This is different with the normal volume detach process.

Besides, when rebuilding, we should only allow detaching the volume with in-use status, volume in status such as 'retyping' should not allowed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/217567

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/217567
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

[Maciej Szankin (mszankin)]

This bug report has an assignee for a while now but there is no patch
for that. It looks like that the chance of getting a patch is low.
I'm going to remove the assignee to signal to others that they can take
over if they like.
If you want to work on this, please:
* add yourself as assignee AND
* set the status to "In Progress" AND
* provide a (WIP) patch within the next 2 weeks after that.
If you need assistance, reach out on the IRC channel #openstack-nova or
use the mailing list.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/734734

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/734734
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=10e9a9b9fc62a3cf72c3717e3621ed95d3cf5519
Submitter: Zuul
Branch: master

commit 10e9a9b9fc62a3cf72c3717e3621ed95d3cf5519
Author: sunhao <[e-mail]>
Date: Wed Jun 10 10:26:49 2020 +0800

    Add checks for volume status when rebuilding

    When rebuilding, we should only allow detaching
    the volume with 'in-use' status, volume in status
    such as 'retyping' should not allowed.

    Change-Id: I7f93cfd18f948134c9cb429dea55740d2cf97994
    Closes-Bug: #1489304

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/747122

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/747122
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bcbeae2c605f4ab4ad805dddccac802928a180b6
Submitter: Zuul
Branch: stable/ussuri

commit bcbeae2c605f4ab4ad805dddccac802928a180b6
Author: sunhao <[e-mail]>
Date: Wed Jun 10 10:26:49 2020 +0800

    Add checks for volume status when rebuilding

    When rebuilding, we should only allow detaching
    the volume with 'in-use' status, volume in status
    such as 'retyping' should not allowed.

    Change-Id: I7f93cfd18f948134c9cb429dea55740d2cf97994
    Closes-Bug: #1489304
    (cherry picked from commit 10e9a9b9fc62a3cf72c3717e3621ed95d3cf5519)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/748558

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/748559

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/748558
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=683005df39cbb825ff0702cd91773ad16d7b3998
Submitter: Zuul
Branch: stable/train

commit 683005df39cbb825ff0702cd91773ad16d7b3998
Author: sunhao <[e-mail]>
Date: Wed Jun 10 10:26:49 2020 +0800

    Add checks for volume status when rebuilding

    When rebuilding, we should only allow detaching
    the volume with 'in-use' status, volume in status
    such as 'retyping' should not allowed.

    Conflicts:
        nova/api/openstack/compute/servers.py
        nova/compute/api.py
        nova/tests/unit/api/openstack/compute/test_server_actions.py
    Modified:
        nova/tests/unit/compute/test_compute_api.py

    NOTE(elod.illes):
    * conflicts in servers.py and test_server_actions.py are due to bug
      fixing patch I25eff0271c856a8d3e83867b448e1dec6f6732ab is not
      backported to stable/train
    * api.py conflict is due to Ic2ad1468d31b7707b7f8f2b845a9cf47d9d076d5
      is part of a feature introduced in Ussuri
    * modification of test_compute_api.py is also required due to patch
      I25eff0271c856a8d3e83867b448e1dec6f6732ab is not backported and
      another patch, Ide8eb9e09d22f20165474d499ef0524aefc67854, that
      cannot be backported to stable/train

    Change-Id: I7f93cfd18f948134c9cb429dea55740d2cf97994
    Closes-Bug: #1489304
    (cherry picked from commit 10e9a9b9fc62a3cf72c3717e3621ed95d3cf5519)
    (cherry picked from commit bcbeae2c605f4ab4ad805dddccac802928a180b6)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/748559
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4130ef8af0331bd1ec363b85c3c5cd827e6ea6c7
Submitter: Zuul
Branch: stable/stein

commit 4130ef8af0331bd1ec363b85c3c5cd827e6ea6c7
Author: sunhao <[e-mail]>
Date: Wed Jun 10 10:26:49 2020 +0800

    Add checks for volume status when rebuilding

    When rebuilding, we should only allow detaching
    the volume with 'in-use' status, volume in status
    such as 'retyping' should not allowed.

    Change-Id: I7f93cfd18f948134c9cb429dea55740d2cf97994
    Closes-Bug: #1489304
    (cherry picked from commit 10e9a9b9fc62a3cf72c3717e3621ed95d3cf5519)
    (cherry picked from commit bcbeae2c605f4ab4ad805dddccac802928a180b6)
    (cherry picked from commit 683005df39cbb825ff0702cd91773ad16d7b3998)