Mess in live-migration compute-manager and drivers code

Bug #1487477 reported by Timofey Durakov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Opinion
Wishlist
Timofey Durakov

Bug Description

There is _live_migration_cleanup_flags method in compute's manager class which should decide whether it's needed to make cleanup after live-migration is done or not. It accepts 2 params, from doc:
 :param block_migration: if true, it was a block migration
 :param migrate_data: implementation specific data
The problem is that current compute's manager code is libvirt-specific.
It operates values in migrate_data dictionary that valid only for libvirt driver implementation.
This doesn't cause any bug yet because other drivers doesn't implement cleanup method at all.
When anyone decide to implement this live-migration starts to fail. There is no valid ci job to verify that.

live_migration_cleanup_flags - should become hypervisor specific. and we should move it from compute manager to drivers.

Changed in nova:
status: New → In Progress
Jay Pipes (jaypipes)
Changed in nova:
importance: Undecided → Low
tags: added: low-hanging-fruit
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/216329

tags: added: live-migrate
removed: live-migration
Paul Murray (pmurray)
tags: added: live-migration
removed: live-migrate
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/216329
Reason: This code hasn't been updated in a long time, and is in merge conflict. I am going to abandon this review, but feel free to restore it if you're still working on this.

Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

As discussed with Timofey in IRC #nova, this needs to be driven most likely by a blueprint.

Changed in nova:
status: In Progress → Opinion
importance: Low → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.