The API for getting console connection info works only for RDP

Bug #1485529 reported by Radoslav Gerganov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Medium
Radoslav Gerganov

Bug Description

There is an API (os-console-auth-tokens) which returns the connection info which correspond to a given console token. However this API works only for RDP consoles:

https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/console_auth_tokens.py#L49

We need the same API for MKS consoles as well. Also I don't see any reason why we should check the console type at all.

Changed in nova:
status: New → In Progress
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

Note: This patch set wants to fix this bug: https://review.openstack.org/#/c/208998/4

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Radoslav Gerganov (<email address hidden>) on branch: master
Review: https://review.openstack.org/208998
Reason: https://review.openstack.org/#/c/331691/

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
Alessandro Pilotti (alexpilotti) wrote :

Sorry, saw this bug just now:

That check for RDP console is IMO totally useless. When the os-console-auth-tokens patch was being reviewed, the reviewers asked to add it, the reason being provided is that people might use it in an "unsupported way", so unfortunately it's still there. I'd definitely support removing that check.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers