xenapi : xen tools scripts needs to be tested

Bug #1481705 reported by Sulochan Acharya on 2015-08-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Low
Unassigned

Bug Description

John Garbutt (johngarbutt) wrote :

or we just remove them, either way.

tags: added: xenserver
Changed in nova:
status: New → Confirmed
importance: Undecided → Low
Bob Ball (bob-ball) wrote :

At least rotate_xen_guest_logs.sh is tested by the XenServer CI.
Some other scripts I believe are in use at Rackspace, and are useful for generic XenServer deployments. If they are to be removed I would suggest moving them to a new repository so they are easily findable.

They are definitely useful. I think we should get test working on these somehow and maintain them. I dont think it matters if its here or somewhere else as long as XenServer deployments can find/use it.

Changed in nova:
assignee: nobody → Sulochan Acharya (sulochan-acharya)
Changed in nova:
assignee: Sulochan Acharya (sulochan-acharya) → nobody

I wonder should we extend this to remove the code in the 'plugins/xenserver' API? This code could do with more tests, or just being moved into a separate project.

Bob Ball (bob-ball) wrote :

I see you've found some of the changes (e.g. https://review.openstack.org/#/c/286383/, https://review.openstack.org/#/c/286445/) to add unit tests for plugins/xenserver :) We'll keep adding more unit tests for the plugins over the next few weeks until they have good coverage. I'm keen for those (and the console crontab job above) to stay in tree.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers