xenapi: xentool - cache destroy script is broken

[Sulochan Acharya]

https://github.com/openstack/nova/blob/master/tools/xenserver/destroy_cached_images.py

is broken, as it has not been updated for a really long time. XenAPIDriver initialization has changed since, along with oslo_config so this script needs to be updated to include those.

[Bob Ball (bob-ball)]

How does this relate to the "Remove these scripts" bug #1481705?
If the suggestion is that this script is broken therefore unusable therefore definitely not being used then let's remove it rather than fix it then remove it with 1481705

[Bob Ball (bob-ball)]

Should we really be removing this and adding support for the "has_imagecache" capability? (I don't know enough about that capability but my initial thought is yes?)

[Sulochan Acharya (sulochan-acharya)]

Bob, yeah i was just chatting with John about cache cleanup in xapi. Are we saying if we get cache cleanup working on cache manger we don't want this particular script or just nuke the whole tools scripts ? I am trying to see if we can get that going as well but want to get an idea of what we want for this script.

[Bob Ball (bob-ball)]

Other scripts are definitely performing other tasks, so I guess it would only affect this script?

[Sulochan Acharya (sulochan-acharya)]

https://review.openstack.org/#/c/209526/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/209526
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d731a04b604fb39ffeb4ba05d42664a15de8508c
Submitter: Jenkins
Branch: master

commit d731a04b604fb39ffeb4ba05d42664a15de8508c
Author: Sulochan Acharya <email address hidden>
Date: Wed Aug 5 14:07:54 2015 +0000

    xapi-tools: fixes cache cleaner script

    Fixes cache cleaner script by removing import of
    driver and using session directly to call vm_utils.

    There is no test included for this. Since this is out of nova
    tree, adding tests is tracked in 1481705

    Closes-Bug: #1481693

    Change-Id: I25ee22777baecaf64de63a39d19e8f8f514f70b3

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/nova 13.0.0.0b1 development milestone.