xenapi: cached images should be cleaned up by time

[Sulochan Acharya]

For xenapi driver, there needs to be some way to delete cached images based on when they were created.

Here is a use case:

Operators often change images frequently for updates etc, if an image has cache_in_nova flag set, xapi will cache it in the SR.
However, the cleanup method, can only handle cleanup of cache that are not used (which is fair enough) but a lot of the times we don't want to clean new images even when they are not used, so there needs to be a way to delete image based on when they were cached.

One approach, for example, could be that we set created timestamp on the image, and be able to delete images depending on when they were cached etc.

[Sujitha (sujitha-neti)]

It's been a while since this bug was assigned and no patch was submitted. Moving it to unassigned.

Sulochan Acharya, please reassign yourself if you are working on this.

[Jianghua Wang (wjh-fresh)]

Looks like we can set the created time and proposal keeping time in VDI's other-config. Basing on these two time parameters to determine if should clean the cached images which is not used at the moment.

[Sean Dague (sdague)]

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

[Sean Dague (sdague)]

Found open reviews for this bug in gerrit, setting to In Progress.

review: https://review.openstack.org/465954 in branch: master

[Jianghua Wang (wjh-fresh)]

removed affects on os-xenapi as this fix should be nova only. We can't move this clean-up script to os-xenapi due to this script has dependence on nova/virt/xenapi/vm_utils.py

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/465954
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=693ace79fbf856967684f11dfd7663d465dbe19a
Submitter: Zuul
Branch: master

commit 693ace79fbf856967684f11dfd7663d465dbe19a
Author: naichuans <email address hidden>
Date: Thu May 18 13:01:06 2017 +0000

    xenapi: cached images should be cleaned up by time

    For xenapi driver, there needs to be some way to delete cached
    images based on when they were created. add an optional arg to
    control delete operation.

    Change-Id: I24fc45e989aa951aab55a261fce77f7e3667d988
    Closes-bug: 1481689

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.0.0b2 development milestone.