Ironic driver needs to handle nodes in CLEANWAIT state

Bug #1479532 reported by Ruby Loo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Ruby Loo

Bug Description

Ironic recently added a new state 'CLEANWAIT' [1] so nodes that previously had their provision state as CLEANING will now be in either CLEANING or CLEANWAIT.

The ironic driver in nova needs to be updated to know about this new CLEANWAIT state. In particular, when destroying an instance, from nova's perspective, the instance has been removed when a node is in CLEANWAIT state.

[1] Ic2bc4f147f68947f53d341fda5e0c8d7b594a553

Tags: ironic
Ruby Loo (rloo)
tags: added: ironic
Changed in nova:
assignee: nobody → Ruby Loo (rloo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/207236

Changed in nova:
status: New → In Progress
Revision history for this message
Ruby Loo (rloo) wrote :

Forgot to add that without this change, nothing breaks. But the destroy process will take longer to finish (from nova's perspective) because we'll have to wait until the node is in CLEANING or AVAILABLE state, so depending on the clean operation happening, it could be quick or take a long time.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/207236
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d4ee7063236b7baf793c39d9ce09159aef91ad18
Submitter: Jenkins
Branch: master

commit d4ee7063236b7baf793c39d9ce09159aef91ad18
Author: Ruby Loo <email address hidden>
Date: Wed Jul 29 21:57:04 2015 +0000

    Instance destroyed if ironic node in CLEANWAIT

    Ironic added a new state 'CLEANWAIT' so nodes that previously had their
    provision state as CLEANING will now be in either CLEANING or CLEANWAIT.

    This patch updates the ironic driver so that it knows about the CLEANWAIT
    state. In particular, when destroying an instance, from nova's perspective,
    the instance has been removed if a node is in CLEANWAIT state.

    Change-Id: Ib42142d67cf2a640a03ec87cbd5fcc0bfdbeb51f
    Closes-Bug: #1479532

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-3 → 12.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers