Add unit tests for libvirt fibrechannel/iser/iscsi/aoe volume drivers after os-brick

[Matt Riedemann]

With change https://review.openstack.org/#/c/175569/ we lost some unit test coverage of connect_volume/disconnect_volume/get_config methods in the libvirt iscsi/fibrechannel/iser/aoe volume drivers, since the actual low-level parts of those are now handled in os-brick but we still need to unit test the calls to os-brick in nova.

I've made comments in https://review.openstack.org/#/c/175569/ where there were things that didn't have test coverage after the change. Some of the other comments are handled in the refactor series here:

https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/consolidate-libvirt-fs-volume-drivers,n,z

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/208401

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/208401
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

[Maciej Szankin (mszankin)]

This bug report has an assignee for a while now but there is no patch
for that. It looks like that the chance of getting a patch is low.
I'm going to remove the assignee to signal to others that they can take
over if they like.
If you want to work on this, please:
* add yourself as assignee AND
* set the status to "In Progress" AND
* provide a (WIP) patch within the next 2 weeks after that.
If you need assistance, reach out on the IRC channel #openstack-nova or
use the mailing list.

Also tagging as New. It is old and requires to be verified.

[Sean Dague (sdague)]

still valid?

[Launchpad Janitor (janitor)]

[Expired for OpenStack Compute (nova) because there has been no activity for 60 days.]