Add unit tests for libvirt fibrechannel/iser/iscsi/aoe volume drivers after os-brick

Bug #1479172 reported by Matt Riedemann on 2015-07-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Low
Unassigned

Bug Description

With change https://review.openstack.org/#/c/175569/ we lost some unit test coverage of connect_volume/disconnect_volume/get_config methods in the libvirt iscsi/fibrechannel/iser/aoe volume drivers, since the actual low-level parts of those are now handled in os-brick but we still need to unit test the calls to os-brick in nova.

I've made comments in https://review.openstack.org/#/c/175569/ where there were things that didn't have test coverage after the change. Some of the other comments are handled in the refactor series here:

https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/consolidate-libvirt-fs-volume-drivers,n,z

Matt Riedemann (mriedem) on 2015-07-29
Changed in nova:
status: New → Confirmed
importance: Undecided → Low
Changed in nova:
assignee: nobody → lyanchih (lyanchih)
Changed in nova:
status: Confirmed → In Progress

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/208401
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

Maciej Szankin (mszankin) wrote :

This bug report has an assignee for a while now but there is no patch
for that. It looks like that the chance of getting a patch is low.
I'm going to remove the assignee to signal to others that they can take
over if they like.
If you want to work on this, please:
* add yourself as assignee AND
* set the status to "In Progress" AND
* provide a (WIP) patch within the next 2 weeks after that.
If you need assistance, reach out on the IRC channel #openstack-nova or
use the mailing list.

Also tagging as New. It is old and requires to be verified.

Changed in nova:
status: In Progress → New
assignee: Chung Chih, Hung (lyanchih) → nobody
Sean Dague (sdague) wrote :

still valid?

Changed in nova:
status: New → Incomplete
Launchpad Janitor (janitor) wrote :

[Expired for OpenStack Compute (nova) because there has been no activity for 60 days.]

Changed in nova:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers