libvirt, rbd imagebackend, disk.rescue not deleted when unrescued

[raphael.glon]

Reproduced on juno version (actually tested on a fork from 2014.2.3, sorry in advance if invalid but i think the legacy version is also concerned by it)

not tested on younger versions, but looking at the code they seem impacted too

For Rbd imagebackend only, when unrescuing an instance the disk.rescue file is actually not deleted on remote storage (only the rbd session is destroyed)

Consequence: when rescuing instance once again, it simply ignores the new rescue image and takes the old _disk.rescue image

Reproduce:

1. nova rescue instance

(take care that you are booted to the vda rescue disk -> when rescuing an instance from the same image it was spawned from (case by default), since fs uuid is the same, according to your image fstab (if entry UUID=) you can actually boot from the image you are actually trying to rescue, but this is another matter that concerns template building -> see https://bugs.launchpad.net/nova/+bug/1460536)

edit rescue image disk

2. nova unrescue instance

3. nova rescue instance -> you get back the disk.rescue spawned in 1

if confirmed, fix coming soon

Concerning fix several possibilities:
- nova.virt.libvirt.driver :LibvirtDriver-> unrescue method, not deleting the correct files
or
- nova.virt.libvirt.imagebackend:Rbd -> erase disk.rescue in create image method if already existing

Rebuild not concerned by issue, delete instance correctly deletes files on remote storage

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/203086

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/203086
Reason: This patch has been stalled for quite a while, so I am going to abandon it to keep the code review queue sane. Please restore the change when it is ready for review.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/314928

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/318089

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bartek Żurawski (<email address hidden>) on branch: master
Review: https://review.openstack.org/318089
Reason: Duplicate

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/314928
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c12d388070895e40be19f4f4e5fded736a5376be
Submitter: Jenkins
Branch: master

commit c12d388070895e40be19f4f4e5fded736a5376be
Author: Bartek Zurawski <email address hidden>
Date: Tue May 10 17:31:19 2016 +0200

    Fix issue with not removing rbd rescue disk

    Currently when instance that use RBD as backend
    is rescued and next unrescued, rescue image is
    not removed, this cause issue when the same
    instance is rescued again it's use old rescue
    image not new one.

    Change-Id: Idf4086303baa4b936c90be89552ad8deb45cef3a
    Closes-Bug: #1475652

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/385925

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/385925
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=332e11c714ced0ffc2921feddffa370ef5475949
Submitter: Jenkins
Branch: stable/newton

commit 332e11c714ced0ffc2921feddffa370ef5475949
Author: Bartek Zurawski <email address hidden>
Date: Tue May 10 17:31:19 2016 +0200

    Fix issue with not removing rbd rescue disk

    Currently when instance that use RBD as backend
    is rescued and next unrescued, rescue image is
    not removed, this cause issue when the same
    instance is rescued again it's use old rescue
    image not new one.

    Change-Id: Idf4086303baa4b936c90be89552ad8deb45cef3a
    Closes-Bug: #1475652
    (cherry picked from commit c12d388070895e40be19f4f4e5fded736a5376be)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 14.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 15.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 14.0.2 release.