VMware: unable to delete VM with attached volumes

[Gary Kotton]

When the ESX running the VM's was deleted or removed the following exception occurred when the instance was deleted via OpenStack:

2015-07-02 21:33:00.638 21297 TRACE oslo.messaging.rpc.dispatcher ManagedObjectNotFound: The object has already been deleted or has not been completely created
2015-07-02 21:33:00.638 21297 TRACE oslo.messaging.rpc.dispatcher Cause: Server raised fault: 'The object has already been deleted or has not been completely created'
2015-07-02 21:33:00.638 21297 TRACE oslo.messaging.rpc.dispatcher Faults: [ManagedObjectNotFound]
2015-07-02 21:33:00.638 21297 TRACE oslo.messaging.rpc.dispatcher Details: {'obj': 'vm-2073'}
2015-07-02 21:33:00.638 21297 TRACE oslo.messaging.rpc.dispatcher
2015-07-02 21:33:00.653 21297 ERROR oslo.messaging._drivers.common [-] Returning exception The object has already been deleted or has not been completely created
Cause: Server raised fault: 'The object has already been deleted or has not been completely created'
Faults: [ManagedObjectNotFound]
Details: {'obj': 'vm-2073'} to caller

This prevent the instance from being deleted in openstack

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/198674
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ec7815960386ba9f522b839144d57a423b930654
Submitter: Jenkins
Branch: master

commit ec7815960386ba9f522b839144d57a423b930654
Author: Gary Kotton <email address hidden>
Date: Mon Jul 6 03:57:17 2015 -0700

    VMware: treat deletion exception with attached volumes

    Enable the OpenStack user to successfully delete an instance that was
    running on an ESX that has been removed, or the instance was deleted from
    the backend VC. In the event that the instance would have an attached
    volume then deleting the instance would not handle the exception
    ManagedObjectNotFound.

    Change-Id: I1781256bec15ed3301425e63c7a3d28dc057f83e
    Closes-bug: #1471751