hostname comparison for foced_host should be case-insensitive

[rick jones]

It would appear that when the scheduler is matching the hostname provided in the --availability-zone option with the hostnames of the compute nodes in a case-sensitive manner. However, going back to the misty Dawn of Internet Time hostnames have been case-insensitive items. As such, the scheduler should be making the comparisons on a case-insensitive basis.

$ /opt/stack/venvs/nova/bin/nova-scheduler --version
2014.2.3

[Markus Zoeller (markus_z) (mzoeller)]

@rick jones:
Thanks for reporting this issue. Could you add the steps on how to reproduce this issue, please? After providing these details, please switch the status of this bug to "New" again. Thanks!

[rick jones (perfgeek)]

1) Become forced_host enabled - either by being admin or by adding the role to a mere mortal user/tenant, or by removing the is_admin:True from the Nova policy.json file
2) Armed with the hostname of a compute node, flip one or more of the characters to upper case when passing that in through the --availability-zone option of Nova boot. For example if the hostname is "foo" use "Foo"
3) You will see a "no valid host found" once the instance goes into ERROR state.

[Ming Yang (mingy)]

It seems that the method `get_filtered_hosts` in nova.scheduler.host_manager does not deal with case insensitivity.

[Ming Yang (mingy)]

Is anybody still working on this? If not, can I take this?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/201725

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/290532

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/290532
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a86f1d129d27f82ca514814164487d23ce728ad9
Submitter: Jenkins
Branch: master

commit a86f1d129d27f82ca514814164487d23ce728ad9
Author: Chris Dent <email address hidden>
Date: Wed Mar 9 14:16:23 2016 +0000

    Make force_ and ignore_hosts comparisons case insensitive

    Hostnames, since the dawn of time, are case insensitive so they
    should be compared thusly when preparing hosts to be filtered.

    Note that this change does not do anything with nodenames.

    Change-Id: I50e2e5cf749f0d39a05ccc373ae1d00824d927ea
    Co-Authored-By: Ming Yang <email address hidden>
    Closes-Bug: #1464348

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/nova 13.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/201725
Reason: This code hasn't been updated in a long time, and is in merge conflict. I am going to abandon this review, but feel free to restore it if you're still working on this.