nova vmware unit tests failing with oslo.vmware 0.13.0

[Matt Riedemann]

http://logs.openstack.org/68/184968/2/check/gate-nova-python27/e3dadf7/console.html#_2015-05-26_20_45_35_734

2015-05-26 20:45:35.734 | {4} nova.tests.unit.virt.vmwareapi.test_vm_util.VMwareVMUtilTestCase.test_create_vm_invalid_guestid [0.058940s] ... FAILED
2015-05-26 20:45:35.735 |
2015-05-26 20:45:35.735 | Captured traceback:
2015-05-26 20:45:35.735 | ~~~~~~~~~~~~~~~~~~~
2015-05-26 20:45:35.736 | Traceback (most recent call last):
2015-05-26 20:45:35.736 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/mock.py", line 1201, in patched
2015-05-26 20:45:35.736 | return func(*args, **keywargs)
2015-05-26 20:45:35.737 | File "nova/tests/unit/virt/vmwareapi/test_vm_util.py", line 796, in test_create_vm_invalid_guestid
2015-05-26 20:45:35.737 | 'folder', config_spec, 'res-pool')
2015-05-26 20:45:35.737 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 422, in assertRaises
2015-05-26 20:45:35.738 | self.assertThat(our_callable, matcher)
2015-05-26 20:45:35.738 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 433, in assertThat
2015-05-26 20:45:35.738 | mismatch_error = self._matchHelper(matchee, matcher, message, verbose)
2015-05-26 20:45:35.738 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 483, in _matchHelper
2015-05-26 20:45:35.739 | mismatch = matcher.match(matchee)
2015-05-26 20:45:35.739 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/matchers/_exception.py", line 108, in match
2015-05-26 20:45:35.739 | mismatch = self.exception_matcher.match(exc_info)
2015-05-26 20:45:35.740 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/matchers/_higherorder.py", line 62, in match
2015-05-26 20:45:35.740 | mismatch = matcher.match(matchee)
2015-05-26 20:45:35.740 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 414, in match
2015-05-26 20:45:35.741 | reraise(*matchee)
2015-05-26 20:45:35.741 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/matchers/_exception.py", line 101, in match
2015-05-26 20:45:35.741 | result = matchee()
2015-05-26 20:45:35.742 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 969, in __call__
2015-05-26 20:45:35.742 | return self._callable_object(*self._args, **self._kwargs)
2015-05-26 20:45:35.742 | File "nova/virt/vmwareapi/vm_util.py", line 1280, in create_vm
2015-05-26 20:45:35.742 | task_info = session._wait_for_task(vm_create_task)
2015-05-26 20:45:35.743 | File "nova/virt/vmwareapi/driver.py", line 714, in _wait_for_task
2015-05-26 20:45:35.743 | return self.wait_for_task(task_ref)
2015-05-26 20:45:35.743 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_vmware/api.py", line 381, in wait_for_task
2015-05-26 20:45:35.744 | return evt.wait()
2015-05-26 20:45:35.744 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/eventlet/event.py", line 121, in wait
2015-05-26 20:45:35.744 | return hubs.get_hub().switch()
2015-05-26 20:45:35.745 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/eventlet/hubs/hub.py", line 294, in switch
2015-05-26 20:45:35.745 | return self.greenlet.switch()
2015-05-26 20:45:35.745 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_vmware/common/loopingcall.py", line 76, in _inner
2015-05-26 20:45:35.745 | self.f(*self.args, **self.kw)
2015-05-26 20:45:35.746 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_vmware/api.py", line 423, in _poll_task
2015-05-26 20:45:35.746 | raise task_ex
2015-05-26 20:45:35.746 | oslo_vmware.exceptions.VimFaultException: Error message
2015-05-26 20:45:35.747 | Faults: ['VMwareDriverException']
2015-05-26 20:45:35.747 |
2015-05-26 20:45:35.747 |
2015-05-26 20:45:35.748 | Captured pythonlogging:
2015-05-26 20:45:35.748 | ~~~~~~~~~~~~~~~~~~~~~~~
2015-05-26 20:45:35.748 | 2015-05-26 20:45:35,632 INFO [oslo_vmware.api] Successfully established new session; session ID is ae214.
2015-05-26 20:45:35.748 | 2015-05-26 20:45:35,633 ERROR [oslo_vmware.common.loopingcall] in fixed duration looping call
2015-05-26 20:45:35.749 | Traceback (most recent call last):
2015-05-26 20:45:35.749 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_vmware/common/loopingcall.py", line 76, in _inner
2015-05-26 20:45:35.749 | self.f(*self.args, **self.kw)
2015-05-26 20:45:35.750 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_vmware/api.py", line 423, in _poll_task
2015-05-26 20:45:35.750 | raise task_ex
2015-05-26 20:45:35.750 | VimFaultException: Error message
2015-05-26 20:45:35.751 | Faults: ['VMwareDriverException']

http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiRmF1bHRzOiBbJ1ZNd2FyZURyaXZlckV4Y2VwdGlvbiddXCIiLCJmaWVsZHMiOltdLCJvZmZzZXQiOjAsInRpbWVmcmFtZSI6IjYwNDgwMCIsImdyYXBobW9kZSI6ImNvdW50IiwidGltZSI6eyJ1c2VyX2ludGVydmFsIjowfSwic3RhbXAiOjE0MzI2NzQ1MzczODN9

https://pypi.python.org/pypi/oslo.vmware/0.13.0

logstash shows this failing starting today, the same day oslo.vmware 0.13.0 was released.

[Matt Riedemann (mriedem)]

I'm guessing this is the change that's breaking the tests:

https://review.openstack.org/#/c/176694/

[Matt Riedemann (mriedem)]

There is a revert here for oslo.vmware: https://review.openstack.org/#/c/185744/

[Matt Riedemann (mriedem)]

This is a change proposed to global-requirements to blacklist the 0.13.0 version from nova:

https://review.openstack.org/#/c/185748/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sabari (<email address hidden>) on branch: master
Review: https://review.openstack.org/185830
Reason: I posted the patch to try and fix nova unit tests for the incompat changes in oslo.vmware. But since we blocked the 0.13.0 in nova and still working on a strategy to address this issue https://etherpad.openstack.org/p/oslo-vmware-13, I am abandoning the change for the time being.

[Matt Riedemann (mriedem)]

More notes and discussion happening here: https://etherpad.openstack.org/p/oslo-vmware-13

[Matt Riedemann (mriedem)]

https://review.openstack.org/#/c/186087/ will unblock nova.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/186087
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f40619b2b4531bf4f06a22124edae35438bf2cc3
Submitter: Jenkins
Branch: master

commit f40619b2b4531bf4f06a22124edae35438bf2cc3
Author: Davanum Srinivas <email address hidden>
Date: Wed May 27 13:13:39 2015 -0400

    Block oslo.vmware 0.13.0 due to a backwards incompatible change

    Lots of details on the global requirements patch that
    this Depends-On.

    Essentially, nova tests are broken with the oslo.vmware
    release and we need to block this version.

    Partial-Bug: #1459021

    Depends-On: Icf1ce8dbb4b2c0b6b627d5d8be0b85a42e99c784
    Change-Id: I4b9a471c9783dff769cbdec2e534bb0157f141f6

[Davanum Srinivas (DIMS) (dims-v)]

0.13.1 is now released with a revert

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/191569

[OpenStack Infra (hudson-openstack)]

Change abandoned by garyk (<email address hidden>) on branch: master
Review: https://review.openstack.org/191569
Reason: The changes in vmware oslo will ensure that we do not need this