ebrctl should be in compute.filters

Bug #1453418 reported by Moshe Levi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Moshe Levi

Bug Description

currently ebrctl is network.filters, but the utility is used by libvirt in nova compute.
need to move it to compute.filters.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/181670

Changed in nova:
assignee: nobody → Moshe Levi (moshele)
status: New → In Progress
Revision history for this message
John Garbutt (johngarbutt) wrote :

Talking on IRC the issue relates to this code:
https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L483

When using ubuntu packages you get compute.filters not network.filters (quite correctly), and it turns out this is in the wrong one.
i.e. this is needed for neutron + nova, when the nova-network package is not installed.

Thats assuming network.filters really is meant to be only for nova-network, and its not clear thats the case right now, although that probably was the intention originally.

Changed in nova:
importance: Undecided → Low
tags: added: libvirt mellanox
Changed in nova:
assignee: Moshe Levi (moshele) → John Garbutt (johngarbutt)
Moshe Levi (moshele)
Changed in nova:
assignee: John Garbutt (johngarbutt) → Moshe Levi (moshele)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/181670
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1e4256f2d04da2984fe2e54914360bd1036fce77
Submitter: Jenkins
Branch: master

commit 1e4256f2d04da2984fe2e54914360bd1036fce77
Author: Moshe Levi <email address hidden>
Date: Sat May 9 19:34:16 2015 +0300

    Move ebrctl to compute.filter.

    Currently ebrctl is network.filters, but the utility is
    used by libvirt in nova compute, as part of a Mellanox vif driver.

    The ubuntu packages install network.filters with the nova-network package.
    But this vif driver only works with Neutron.

    To help fix that, this patch move it to compute.filters to ensure it is
    always installed with Nova.

    Closes-Bug: #1453418

    Change-Id: Ib61a565c10edfa662c15fac339b2cbd9bb673631

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-1 → 12.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.