dynamic nova.conf generation does not work without python-barbicanclient installed

[Matthew Thode]

In gentoo we dynamically generate the docs (we also package stable branch releases that install from git). This doesn't work unless python-barbicanclient is installed.

What I would like to see is either a silent failure with that section of nova.conf removed or just add python-barbicanclient to requirements from test-requirements. I understand that it is expected that example conf generation is expected to need test-requirements, but I don't agree :P

Let me know if you need more info.

[Joe Gordon (jogo)]

IMHO, we should be able to fail gracefully if some part of the sample config generation fails. Barbican isn't needed by default so I don't think we should move it into requirements. This whole thing is yet another manifestation of having optional dependencies and how to represent that.

[Joe Gordon (jogo)]

Issue discovered on stable/kilo

[Matt Riedemann (mriedem)]

python-barbicanclient is in test-requirements.txt, the readme says to use tox -e genconfig, this isn't nova's problem.

If you're not using tox, then install the packages via site-packages and pip, or rpm, or apt-get, or whatever your distro builds require.

[Matthew Thode (prometheanfire)]

Here's the snippet from tox.ini

[testenv:genconfig]
commands = bash tools/config/generate_sample.sh -b . -p nova -o etc/nova

That command has this line in it, it makes me think that tests should not be needed...

FILES=$(find $TARGETDIR -type f -name "*.py" ! -path "*/tests/*" \
              -exec grep -l "Opt(" {} + | sed -e "s/^$BASEDIRESC\///g" | sort -u)

[Sylvain Bauza (sylvain-bauza)]

But tox.ini has both requirements.txt and test-requirements.txt as dependencies, so you need to pull all the packages.