Clean up operation not performed properly by nova .

[sonu]

while I associate a floating IP to an instance and when I remove fixed IP associated to that instance , fixed IP as well as floating IP are removed but when I list floating IP for the current tenant , floating IP list still maintains the old data . Floating IP list still shows the attachment of the fixed IP with the instance from which it was removed that is required clean up operations was not performed properly .

I reproduced this bug using the following steps:-

vyom@vyom:~$ nova list
+--------------------------------------+-----------------+--------+------------+-------------+--------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-----------------+--------+------------+-------------+--------------------------------+
| 7d4a97df-f0e0-4a15-bd1f-1e0d3e76c434 | instance3 | ACTIVE | - | Running | private=10.0.0.18 |
| 973cc64d-ee93-4419-8e1f-9b5f413eed6f | test_instance22 | ACTIVE | - | Running | private=10.0.0.201, 172.24.4.5 |
+--------------------------------------+-----------------+--------+------------+-------------+--------------------------------+

vyom@vyom:~$ nova floating-ip-list
+-------------+--------------------------------------+------------+--------+
| Ip | Server Id | Fixed Ip | Pool |
+-------------+--------------------------------------+------------+--------+
| 172.24.4.10 | - | - | public |
| 172.24.4.16 | - | - | public |
| 172.24.4.15 | - | - | public |
| 172.24.4.11 | - | - | public |
| 172.24.4.7 |- | - | public |
| 172.24.4.12 | - | - | public |
| 172.24.4.5 | 973cc64d-ee93-4419-8e1f-9b5f413eed6f | 10.0.0.201 | public |
| 172.24.4.13 | - | - | public |
| 172.24.4.9 | - | - | public |
| 172.24.4.14 | - | - | public |
 +-------------+--------------------------------------+------------+--------+

*Associating floating IP 172.24.4.10 to instance3 .
vyom@vyom:~$ nova floating-ip-associate 7d4a97df-f0e0-4a15-bd1f-1e0d3e76c434 172.24.4.10

vyom@vyom:~$ nova list
+--------------------------------------+-----------------+--------+------------+-------------+--------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-----------------+--------+------------+-------------+--------------------------------+
| 7d4a97df-f0e0-4a15-bd1f-1e0d3e76c434 | instance3 | ACTIVE | - | Running | private=10.0.0.18, 172.24.4.10 |
| 973cc64d-ee93-4419-8e1f-9b5f413eed6f | test_instance22 | ACTIVE | - | Running | private=10.0.0.201, 172.24.4.5 |
+--------------------------------------+-----------------+--------+------------+-------------+--------------------------------+

vyom@vyom:~$ nova floating-ip-list
+-------------+--------------------------------------+------------+--------+
| Ip | Server Id | Fixed Ip | Pool |
+-------------+--------------------------------------+------------+--------+
| 172.24.4.10 | 7d4a97df-f0e0-4a15-bd1f-1e0d3e76c434 | 10.0.0.18 | public |
| 172.24.4.16 | - | - | public |
| 172.24.4.15 | - | - | public |
| 172.24.4.11 | - | - | public |
| 172.24.4.7 | - | - | public |
| 172.24.4.12 | - | - | public |
| 172.24.4.5 | 973cc64d-ee93-4419-8e1f-9b5f413eed6f | 10.0.0.201 | public |
| 172.24.4.13 | - | - | public |
| 172.24.4.9 | - | - | public |
| 172.24.4.14 | - | - | public |
+-------------+--------------------------------------+------------+--------+

* Removing fixed ip from instance instance3

vyom@vyom:~$ nova remove-fixed-ip 7d4a97df-f0e0-4a15-bd1f-1e0d3e76c434 10.0.0.18

vyom@vyom:~$ nova list
+--------------------------------------+-----------------+--------+------------+-------------+--------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-----------------+--------+------------+-------------+--------------------------------+
| 7d4a97df-f0e0-4a15-bd1f-1e0d3e76c434 | instance3 | ACTIVE | - | Running | |
| 973cc64d-ee93-4419-8e1f-9b5f413eed6f | test_instance22 | ACTIVE | - | Running | private=10.0.0.201, 172.24.4.5 |
+--------------------------------------+-----------------+--------+------------+-------------+--------------------------------+

* Floating IP list still shows the old information .

vyom@vyom:~$ nova floating-ip-list

+-------------+--------------------------------------+------------+--------+
| Ip | Server Id | Fixed Ip | Pool |
+-------------+--------------------------------------+------------+--------+
| 172.24.4.10 | 7d4a97df-f0e0-4a15-bd1f-1e0d3e76c434 | 10.0.0.18 | public |
| 172.24.4.16 | - | - | public |
| 172.24.4.15 | - | - | public |
| 172.24.4.11 | - | - | public |
| 172.24.4.7 | - | - | public |
| 172.24.4.12 | - | - | public |
| 172.24.4.5 | 973cc64d-ee93-4419-8e1f-9b5f413eed6f | 10.0.0.201 | public |
| 172.24.4.13 | - | - | public |
| 172.24.4.9 | - | - | public |
| 172.24.4.14 | - | - | public |
 +-------------+--------------------------------------+------------+--------+

I think association of fixed IP 10.0.0.18 and server Id 7d4a97df-f0e0-4a15-bd1f-1e0d3e76c434 to floating IP 172.24.4.10 should be removed from the list of floating IP .

[Markus Zoeller (markus_z) (mzoeller)]

This bug report has an assignee for a while now but there is no patch
for that. It looks like that the chance of getting a patch is low.
I'm going to remove the assignee to signal to others that they can take
over if they like.

If you want to work on this, please:
* add yourself as assignee AND
* set the status to "In Progress" AND
* provide a (WIP) patch within the next 2 weeks after that.

If you need assistance, reach out on the IRC channel #openstack-nova or
use the mailing list.

[Sean Dague (sdague)]

There are no currently open reviews on this bug, changing
the status back to the previous state and unassigning. If
there are active reviews related to this bug, please include
links in comments.

[Matt Riedemann (mriedem)]

The affected API is deprecated now, see the reasoning in bug https://bugs.launchpad.net/nova/+bug/1525101 but we likely won't fix this at this point.