instances internal_id attribute not in use

[Attila Fazekas]

The nova instances table contains internal_id field, Looks like it is always NULL and never referenced.

The ec2 API uses a variable with same name for snapshots and volumes, but not for instance id.

For the ec2 id -> uuid mapping now a separated table is responsible:
instance_id_mappings which contains an id Integer for ec2 instance-000001 strings and referencing to the instances table with an uuid.

Instead of using instance_id_mappings the internal_id field could be used.

Note.: The ec2 could use the instances.id, but the ec2 users does not likes the random instance-id change, so it might need a special handling.

[Noel Nelson Dsouza (noelnelson)]

Attila Fazekas,

Please provide the steps to reproduce the bug which you followed to face this issue..
Based on that i can start on that bug.

Regards
Noel Nelson Dsouza

[Attila Fazekas (afazekas)]

Noel Nelson Dsouza,

Do you see the 'internal_id' attribute on 'instances' table ever set to anything else than NULL ?
My git grep does not see it and after tempest run I do not see any non NULL value in this field.

Regards,
afazekas

[Markus Zoeller (markus_z) (mzoeller)]

The ec2 stuff got mostly removed with [1]. This looks like a remnant.
IIUC this needs a deprecation phase and then we can drop the column [2].

If you want to work on this, please:
* add yourself as assignee AND
* set the status to "In Progress" AND
* provide a (WIP) patch within the next 2 weeks after that.

If you need assistance, reach out on the IRC channel #openstack-nova or
use the mailing list.

References:
[1] https://git.openstack.org/cgit/openstack/nova/commit/?id=4140eb4
[2] http://docs.openstack.org/developer/nova/upgrade.html#migration-policy

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/360666

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/360666
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=94d5c886ba2b19288276e517317fcd74cc8e4592
Submitter: Jenkins
Branch: master

commit 94d5c886ba2b19288276e517317fcd74cc8e4592
Author: Pushkar Umaranikar <email address hidden>
Date: Thu Sep 22 21:28:00 2016 +0000

    Remove internal_id attribute from instances table

    internal_id attribute column from instances table is no
    longer used. This commit removes internal_id from object
    layer.

    In the later release, this can be removed from schema
    by adding migration script.

    Change-Id: Ia285a16a8fab38a61959df847d30bce2d60ad081
    Closes-Bug: #1441242

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 15.0.0.0b1 development milestone.