Error checking for instance_extra during _run_pending_deletes

[Andrew Laski]

2015-03-31 21:08:01.771 2107 ERROR nova.openstack.common.periodic_task [req- - - - - -] Er
ror during ComputeManager._run_pending_deletes: 'NoneType' object has no attribute 'get'
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task Traceback (most recent call last):
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task File "/opt/rackstack/rackstack.220.0/nova/lib/python2
.7/site-packages/nova/openstack/common/periodic_task.py", line 224, in run_periodic_tasks
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task task(self, context)
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task File "/opt/rackstack/rackstack.220.0/nova/lib/python2
.7/site-packages/nova/compute/manager.py", line 6600, in _run_pending_deletes
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task context, filters, expected_attrs=attrs, use_slave=T
rue)
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task File "/opt/rackstack/rackstack.220.0/nova/lib/python2
.7/site-packages/nova/objects/base.py", line 163, in wrapper
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task result = fn(cls, context, *args, **kwargs)
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task File "/opt/rackstack/rackstack.220.0/nova/lib/python2
.7/site-packages/nova/objects/instance.py", line 1134, in get_by_filters
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task return _make_instance_list(context, cls(), db_inst_
list,
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task File "/opt/rackstack/rackstack.220.0/nova/lib/python2
.7/site-packages/nova/objects/instance.py", line 1066, in _make_instance_list
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task context, objects.Instance(context), db_inst,
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task File "/opt/rackstack/rackstack.220.0/nova/lib/python2
.7/site-packages/nova/objects/instance.py", line 519, in _from_db_object
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task migrated_flavor = instance._maybe_migrate_flavor(db
_inst,
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task File "/opt/rackstack/rackstack.220.0/nova/lib/python2
.7/site-packages/nova/objects/instance.py", line 463, in _maybe_migrate_flavor
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task if db_inst.get('extra', None) is not None and db_in
st.get('extra').get('flavor', None) is not None:
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task AttributeError: 'NoneType' object has no attribute 'get
'
2015-03-31 21:08:01.771 2107 TRACE nova.openstack.common.periodic_task

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/169517

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/169517
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ae870634d152c3120364775b95220f07ddf3e1fb
Submitter: Jenkins
Branch: master

commit ae870634d152c3120364775b95220f07ddf3e1fb
Author: Andrew Laski <email address hidden>
Date: Tue Mar 31 17:26:30 2015 -0400

    Update check before migrating flavor

    db_inst.get('extra', {}) returns {} if 'extra' is not in db_inst, but
    not if db_inst['extra'] is None. Since the result of that is accessed
    like a dict the access of 'extra' has been changed to ensure that we get
    a dict.

    Change-Id: I3755151306ef784119aca0d5ee20fd0455116f64
    Closes-Bug: 1438923