specification of a nova network to instance during icehouse->juno partial upgrade fails

Bug #1438920 reported by Adam Gandelman
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Adam Gandelman
Juno
Fix Released
Undecided
Adam Gandelman

Bug Description

Tempest recently made some changes around specifying fixed network to instances during spawn. When this happens during an icehouse->juno partial upgrade, we fail to spawn instances and they are stuck in scheduling.

Conductor logs show:

oslo.messaging.rpc.dispatcher [req-047d24c2-6477-4838-afde-cc3c7371b19e VolumesV2ActionsTest-21337662 VolumesV2ActionsTest-1578486140] Exception during message handling: need more than 2 values to unpack

It looks like there is code in Nova to handle this case during an icehouse partial upgrade, but only takes into account doing so with Neutron:
https://git.openstack.org/cgit/openstack/nova/tree/nova/compute/rpcapi.py#n982 This needs some special casing to handle NetworkRequestList objects for nova-network, as well.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/169534

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/169538

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/169534
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e69a74f365eca2239fe7649a389224749eea6749
Submitter: Jenkins
Branch: master

commit e69a74f365eca2239fe7649a389224749eea6749
Author: Adam Gandelman <email address hidden>
Date: Tue Mar 31 15:05:26 2015 -0700

    Handle nova-network tuple format in legacy RPC calls

    The NetworkRequestList object renders tuples differently depending on
    network manager. When falling back to older RPC APIs we are missing
    the special casing for the nova network, causing things to blow
    up during icehouse->juno partial upgrades when specifying a network
    with during instance spawn.

    Change-Id: I792f64aa5cbbe9666505d1c7958796c771d4aff2
    Closes-bug: #1438920

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/juno)

Reviewed: https://review.openstack.org/169538
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=db827c7307720de14aeaf20568678fa6450197bd
Submitter: Jenkins
Branch: stable/juno

commit db827c7307720de14aeaf20568678fa6450197bd
Author: Adam Gandelman <email address hidden>
Date: Tue Mar 31 15:05:26 2015 -0700

    Handle nova-network tuple format in legacy RPC calls

    The NetworkRequestList object renders tuples differently depending on
    network manager. When falling back to older RPC APIs we are missing
    the special casing for the nova network, causing things to blow
    up during icehouse->juno partial upgrades when specifying a network
    with during instance spawn.

    Change-Id: I792f64aa5cbbe9666505d1c7958796c771d4aff2
    Closes-bug: #1438920
    (cherry picked from commit 9198a47843b8ea19eb80c7a50998cd06367851dc)

tags: added: in-stable-juno
Changed in nova:
assignee: nobody → Adam Gandelman (gandelman-a)
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.