Cells Response serialization was incorrect for NovaObjects

Bug #1438601 reported by Sylvain Bauza
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Invalid
Medium
Sylvain Bauza

Bug Description

In nova.cells.messaging.Response, the serialization/deserialization was done using the oslo.serialization library which is not correctly serializing a NovaObject because it will loose all related attributes about versioning and classes. Consequently, when deserializing, it will be rehydrated into a dict instead of a NovaObject.

http://git.openstack.org/cgit/openstack/nova/tree/nova/cells/messaging.py?id=9c45ff348d7eb75ae8098b6c950db549aaff282a#n1852

The fix is easy and should call objects_base.serialize_entity() instead.

Tags: cells
Changed in nova:
status: New → Confirmed
status: Confirmed → New
Sean Dague (sdague)
Changed in nova:
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/169400

Changed in nova:
status: Triaged → In Progress
Revision history for this message
melanie witt (melwitt) wrote :

Hi, I had opened https://bugs.launchpad.net/nova/+bug/1438514 for this before.

Revision history for this message
Sylvain Bauza (sylvain-bauza) wrote :
Changed in nova:
status: In Progress → Invalid
milestone: kilo-rc1 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.