ComputeNode and Service objects out of sync with db schema

Bug #1438189 reported by Hans Lindgren on 2015-03-30
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Medium
Unassigned

Bug Description

A recent commit [1] removed the relationship between compute_node and service tables and in addition also made the compute_node.service_id column nullable. These changes were never replicated to the object counterparts.

[1] 551be2c52a29cb2755de4825a3fcb2c8f7d7b3f1

Related fix proposed to branch: master
Review: https://review.openstack.org/168907

Changed in nova:
status: New → In Progress

Reviewed: https://review.openstack.org/168907
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=20a22adc3cb97b6da5c9e1e72171688af3a75e50
Submitter: Jenkins
Branch: master

commit 20a22adc3cb97b6da5c9e1e72171688af3a75e50
Author: Hans Lindgren <email address hidden>
Date: Mon Mar 30 13:53:17 2015 +0200

    Don't query compute_node through service object in nova-manage

    The relationship between compute_node and service tables was
    removed in a recent commit and to be able to remove compat code in
    the objects, calls to get them should be done directly instead of
    going through one or the other.

    Since we are really just interested in the compute_node object here
    this in addition saves us one extra db call.

    Change-Id: I5270882321f7d16f993746498f751f17b0cb52fd
    Related-Bug: #1438189

Change abandoned by Joe Gordon (<email address hidden>) on branch: master
Review: https://review.openstack.org/168908
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Reviewed: https://review.openstack.org/169284
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0b177f18264ca842e16c2c989a081e773b3d86b7
Submitter: Jenkins
Branch: master

commit 0b177f18264ca842e16c2c989a081e773b3d86b7
Author: Hans Lindgren <email address hidden>
Date: Tue Mar 31 13:37:52 2015 +0200

    Make ComputeNode.service_id nullable to match db schema

    The compute_node table was recently updated to make service_id column
    nullable[1]. This mirrors that change to the ComputeNode object.

    [1] 551be2c52a29cb2755de4825a3fcb2c8f7d7b3f1

    Change-Id: I54e81fe7662039d4bf51babcbd2a0d597f98377a
    Related-Bug: #1438189

Changed in nova:
assignee: Hans Lindgren (hanlind) → nobody
status: In Progress → Confirmed
guoweikang (laoyekang) on 2017-05-18
Changed in nova:
assignee: nobody → guoweikang (laoyekang)
status: Confirmed → In Progress
Sean Dague (sdague) wrote :

There are no currently open reviews on this bug, changing
the status back to the previous state and unassigning. If
there are active reviews related to this bug, please include
links in comments.

Changed in nova:
status: In Progress → Confirmed
assignee: guoweikang (laoyekang) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers