nova flavor-list swap size is shown blank, it should be 0 as ephemeral

[yatin]

nova flavor-list swap size is shown blank, it should be 0 as ephemeral for consistency and good user experience. Also it is not clear the size shown is in which unit.

Steps to reproduce:-
> nova flavor-list
+--------------------------------------+----------------+-----------+------+-----------+------+-------+-------------+-----------+
| ID | Name | Memory_MB | Disk | Ephemeral | Swap | VCPUs | RXTX_Factor | Is_Public |
+--------------------------------------+----------------+-----------+------+-----------+------+-------+-------------+-----------+
| 1 | m1.tiny | 512 | 1 | 0 | | 1 | 1.0 | True |
| 2 | m1.small | 2048 | 20 | 0 | | 1 | 1.0 | True |
| 3 | m1.medium | 4096 | 40 | 0 | | 2 | 1.0 | True |
| 4 | m1.large | 8192 | 80 | 0 | | 4 | 1.0 | True |
| 42 | nano | 64 | 1 | 0 | | 1 | 1.0 | False |
| 5 | m1.xlarge | 16384 | 160 | 0 | | 8 | 1.0 | True |
| 51bd5d47-1935-45f4-84db-5958f4d8a0fd | OTC | 3096 | 30 | 0 | | 1 | 1.0 | True |
| 7 | macro | 1024 | 5 | 0 | | 1 | 1.0 | True |
| 82 | test_flav | 1024 | 1 | 0 | 20 | 1 | 1.0 | True |
| 9 | computeFlavor | 8192 | 30 | 0 | | 4 | 1.0 | True |
| cc711fc7-42ed-4d41-bb09-5cf637f2b8cb | OsInstallation | 8192 | 20 | 15 | 4 | 4 | 1.0 | True |
+--------------------------------------+----------------+-----------+------+-----------+------+-------+-------------+-----------+

Here ephemeral disk is shown as 0, but swap space is shown "" when doesn't exist. It should also be displayed as 0, also user doesn't know what unit of size is used to display resources. Size unit should also be displayed in output table header.

[Ritesh Paiboina (rsritesh)]

Hi Yatin, fix has been done for this .
Please free to update the patch.

[Matthew Gilliard (matthew-gilliard-u)]

Perhaps it doesn't auto-link here because the patch is to nova, not python-novaclient? Anyway...

https://review.openstack.org/#/c/188781/1

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/474517
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=34f0259a5ee94648a4be960064d811754c10a93e
Submitter: Jenkins
Branch: master

commit 34f0259a5ee94648a4be960064d811754c10a93e
Author: jichenjc <email address hidden>
Date: Sun May 28 06:15:26 2017 +0800

    Update api-ref to indicate swap param

    swap output is actully an empty string ('') now when query
    flavor if the swap is 0, so we need indicate that before we
    sort out any conclusion (whether we need fix it or not).

    Change-Id: I5a5397479dd894f90dad9a1de509a50f6b3b5477
    Related-Bug: 1436683

[Sean Dague (sdague)]

Found open reviews for this bug in gerrit, setting to In Progress.

review: https://review.openstack.org/471715 in branch: master

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/471715
Reason: This review is > 4 weeks without comment, and is not mergable in it's current state. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Sean Dague (sdague)]

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.