cells: Error processing message locally: Object action save failed because: Calling remotables with context is deprecated

[Matt Riedemann]

Looks like this breaks the cells non-voting job:

http://logs.openstack.org/90/163890/1/check/check-tempest-dsvm-cells/896e7e0/logs/screen-n-cell-child.txt.gz?level=TRACE#_2015-03-12_17_44_00_202

2015-03-12 17:44:00.202 ERROR nova.cells.messaging [req-f0a74b8e-f85f-4711-ac78-ecca301bdd08 DeleteServersTestJSON-678023458 DeleteServersTestJSON-122475576] Error processing message locally: Object action save failed because: Calling remotables with context is deprecated
2015-03-12 17:44:00.202 19800 TRACE nova.cells.messaging Traceback (most recent call last):
2015-03-12 17:44:00.202 19800 TRACE nova.cells.messaging File "/opt/stack/new/nova/nova/cells/messaging.py", line 200, in _process_locally
2015-03-12 17:44:00.202 19800 TRACE nova.cells.messaging resp_value = self.msg_runner._process_message_locally(self)
2015-03-12 17:44:00.202 19800 TRACE nova.cells.messaging File "/opt/stack/new/nova/nova/cells/messaging.py", line 1306, in _process_message_locally
2015-03-12 17:44:00.202 19800 TRACE nova.cells.messaging return fn(message, **message.method_kwargs)
2015-03-12 17:44:00.202 19800 TRACE nova.cells.messaging File "/opt/stack/new/nova/nova/cells/messaging.py", line 838, in instance_update_from_api
2015-03-12 17:44:00.202 19800 TRACE nova.cells.messaging expected_task_state=expected_task_state)
2015-03-12 17:44:00.202 19800 TRACE nova.cells.messaging File "/opt/stack/new/nova/nova/objects/base.py", line 186, in wrapper
2015-03-12 17:44:00.202 19800 TRACE nova.cells.messaging reason='Calling remotables with context is deprecated')
2015-03-12 17:44:00.202 19800 TRACE nova.cells.messaging ObjectActionError: Object action save failed because: Calling remotables with context is deprecated
2015-03-12 17:44:00.202 19800 TRACE nova.cells.messaging

Introduced with this change: https://review.openstack.org/#/c/160500/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163978

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/163978
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fe1fd8247450991b041c261ad3f8c7d0ae3b8d7a
Submitter: Jenkins
Branch: master

commit fe1fd8247450991b041c261ad3f8c7d0ae3b8d7a
Author: Matt Riedemann <email address hidden>
Date: Thu Mar 12 14:13:15 2015 -0700

    cells: don't pass context to instance.save in instance_update_from_api

    Commit 1cf0890fdd23dbf29d03659ad6e8569b3f6e003f creates a wedge whenever
    someone tries to pass a context to a remotable nova object method, like
    instance.save(). There was still an occurrence of this happening in
    cells so let's clean it up and make cells happy(ish) again.

    Closes-Bug: #1431562

    Change-Id: I58e626cb37fe4d34010f6b881f06f0d10f1e6e78