Libvirt Snapshot Test Cleanup
Bug #1425187 reported by
Rick Harris
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Fix Released
|
Low
|
Rick Harris | ||
Bug Description
The Libvirt snapshot tests contain quite a bit of copy and pasted code.
Readability and modifiability would be improved if we DRY up this code.
Another benefit for downstream deployers is, the code becomes more patchable since we have few hunks with the exact same context lines, meaning that the patch algorithm has less of chance of becoming confused and misapplying the patch.
| Changed in nova: | |
| assignee: | nobody → Rick Harris (rconradharris) |
| Changed in nova: | |
| status: | New → In Progress |
| Changed in nova: | |
| importance: | Undecided → Low |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to nova (master) | #1 |
| Changed in nova: | |
| status: | In Progress → Fix Committed |
| Changed in nova: | |
| milestone: | none → kilo-3 |
| status: | Fix Committed → Fix Released |
| Changed in nova: | |
| milestone: | kilo-3 → 2015.1.0 |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 7a680cb804a8ff0
Author: Rick Harris <email address hidden>
Date: Tue Feb 17 17:26:21 2015 -0600
libvirt: Cleanup snapshot tests
The snapshot tests suffered from quite a bit of code duplication making the
tests hard to read and difficult to change later on.
This patch refactors tests into a separate classes which use inheritance to
avoid the duplication.
Closes-Bug: 1425187
Change-Id: I0d4e652b41054b