OpenStack Compute (nova)

DB API fixed_ip_associate() still uses SELECT FOR UPDATE

Bug #1424792 reported by Jay Pipes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Pavel Kholkin
OpenStack Compute (nova) 2015.1.0 "kilo"

Bug Description

Nova's DB API fixed_ip_associate() method is still using with_lockmode('update'). It should be updated to use a compare and swap technique with a retry loop.

OpenStack Infra (hudson-openstack)
Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/153558
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1baa0045876ee7854f9a0216e82ff9639154aa6f
Submitter: Jenkins
Branch: master

commit 1baa0045876ee7854f9a0216e82ff9639154aa6f
Author: pkholkin <email address hidden>
Date: Fri Feb 6 16:30:05 2015 +0400

    Replace select-for-update in fixed_ip_associate

    MySQL Galera does not support the write-intent locks
    that SELECT FOR UPDATE requires. In this patch SELECT
    FOR UPDATE in 'fixed_ip_associate' function
    was replaced with SELECT and UPDATE.

    Closes-bug: #1424792

    Change-Id: Icdc00adcc58becba74f10341e15bd870c8dc5826

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.