test_delete_server_while_in_verify_resize_state fails with "ValueError: You must specify a valid interface name."

[Matt Riedemann]

http://logs.openstack.org/24/156324/3/gate/gate-tempest-dsvm-neutron-full/21b554f/logs/screen-n-cpu.txt.gz?level=TRACE#_2015-02-17_11_45_29_763

2015-02-17 11:45:29.763 ERROR nova.compute.manager [req-02181adb-1b8b-48b1-ad72-ef5a650789e1 DeleteServersTestJSON-42620796 DeleteServersTestJSON-345447266] [instance: 96993b52-7955-4c64-95e2-b332471e1915] Setting instance vm_state to ERROR
2015-02-17 11:45:29.763 4456 TRACE nova.compute.manager [instance: 96993b52-7955-4c64-95e2-b332471e1915] Traceback (most recent call last):
2015-02-17 11:45:29.763 4456 TRACE nova.compute.manager [instance: 96993b52-7955-4c64-95e2-b332471e1915] File "/opt/stack/new/nova/nova/compute/manager.py", line 6188, in _error_out_instance_on_exception
2015-02-17 11:45:29.763 4456 TRACE nova.compute.manager [instance: 96993b52-7955-4c64-95e2-b332471e1915] yield
2015-02-17 11:45:29.763 4456 TRACE nova.compute.manager [instance: 96993b52-7955-4c64-95e2-b332471e1915] File "/opt/stack/new/nova/nova/compute/manager.py", line 3850, in resize_instance
2015-02-17 11:45:29.763 4456 TRACE nova.compute.manager [instance: 96993b52-7955-4c64-95e2-b332471e1915] timeout, retry_interval)
2015-02-17 11:45:29.763 4456 TRACE nova.compute.manager [instance: 96993b52-7955-4c64-95e2-b332471e1915] File "/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 5939, in migrate_disk_and_power_off
2015-02-17 11:45:29.763 4456 TRACE nova.compute.manager [instance: 96993b52-7955-4c64-95e2-b332471e1915] shared_storage = self._is_storage_shared_with(dest, inst_base)
2015-02-17 11:45:29.763 4456 TRACE nova.compute.manager [instance: 96993b52-7955-4c64-95e2-b332471e1915] File "/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 5891, in _is_storage_shared_with
2015-02-17 11:45:29.763 4456 TRACE nova.compute.manager [instance: 96993b52-7955-4c64-95e2-b332471e1915] shared_storage = (dest == self.get_host_ip_addr())
2015-02-17 11:45:29.763 4456 TRACE nova.compute.manager [instance: 96993b52-7955-4c64-95e2-b332471e1915] File "/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 2460, in get_host_ip_addr
2015-02-17 11:45:29.763 4456 TRACE nova.compute.manager [instance: 96993b52-7955-4c64-95e2-b332471e1915] ips = compute_utils.get_machine_ips()
2015-02-17 11:45:29.763 4456 TRACE nova.compute.manager [instance: 96993b52-7955-4c64-95e2-b332471e1915] File "/opt/stack/new/nova/nova/compute/utils.py", line 470, in get_machine_ips
2015-02-17 11:45:29.763 4456 TRACE nova.compute.manager [instance: 96993b52-7955-4c64-95e2-b332471e1915] iface_data = netifaces.ifaddresses(interface)
2015-02-17 11:45:29.763 4456 TRACE nova.compute.manager [instance: 96993b52-7955-4c64-95e2-b332471e1915] ValueError: You must specify a valid interface name.
2015-02-17 11:45:29.763 4456 TRACE nova.compute.manager [instance: 96993b52-7955-4c64-95e2-b332471e1915]

http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiVmFsdWVFcnJvcjogWW91IG11c3Qgc3BlY2lmeSBhIHZhbGlkIGludGVyZmFjZSBuYW1lLlwiIEFORCBtZXNzYWdlOlwiZ2V0X21hY2hpbmVfaXBzXCIgQU5EIG1lc3NhZ2U6XCJtaWdyYXRlX2Rpc2tfYW5kX3Bvd2VyX29mZlwiIEFORCB0YWdzOlwic2NyZWVuLW4tY3B1LnR4dFwiIiwiZmllbGRzIjpbXSwib2Zmc2V0IjowLCJ0aW1lZnJhbWUiOiJjdXN0b20iLCJncmFwaG1vZGUiOiJjb3VudCIsInRpbWUiOnsiZnJvbSI6IjIwMTUtMDItMDNUMjA6NDU6NDcrMDA6MDAiLCJ0byI6IjIwMTUtMDItMTdUMjA6NDU6NDcrMDA6MDAiLCJ1c2VyX2ludGVydmFsIjoiMCJ9LCJzdGFtcCI6MTQyNDIwNjAzNzg2OX0=

48 hits in the last 10 days, started on 2/12 so we merged something bad (or neutron did), check and gate, all failures.

[Matt Riedemann (mriedem)]

Hmm, this merged on 2/12:

https://github.com/openstack/nova/commit/8fc7eee58ebd929dda75e467f93c381091da7ace

[Matt Riedemann (mriedem)]

Actually it's this:

https://github.com/openstack/nova/commit/b838ca28e0ffda21b298a4514a647fc74c154f4a

The merge commit was on 2/11:

https://github.com/openstack/nova/commit/ede75c15637acb3a8d8899620f71087796bd1c3f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/156781

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/156781
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=82d492263a74854138ceb6ee53f5f5ca6efe3018
Submitter: Jenkins
Branch: master

commit 82d492263a74854138ceb6ee53f5f5ca6efe3018
Author: Matt Riedemann <email address hidden>
Date: Tue Feb 17 13:10:04 2015 -0800

    Expand try/except for get_machine_ips

    Commit b838ca28e0ffda21b298a4514a647fc74c154f4a added get_machine_ips
    and copied it from swift but didn't put the try/except in the same
    scope, essentially swift commit 76afb46d91bb32dfcbda829408d6b0735526b92f.
    This causes a ValueError failure race bug in resize tests in the gate.

    This change simply expands the scope of the try/except like it is in
    swift and adds a test to cover that.

    Note that we should move this utility function into oslo at some point
    if multiple projects are needing this.

    Closes-Bug: #1422901

    Change-Id: Iccceca4b9706ac7723563fbd2065f40586400527