The publisher_id field is missing the service name sometimes

[Simon Pasquier]

In the notifications emitted by the Nova services, the 'publisher_id' fields is sometimes equal to 'None.<node name>' while it is '<service name>.<node name>' (eg, 'conductor.node-1') otherwise. From what I can tell, the "problem" is located in nova/objects/instance.py (see [1] and [2]).
This isn't a huge issue (eg instances can be created, deleted and so on) but it makes it problematic when trying to rely on this field for external processing/computation.

[1] http://git.openstack.org/cgit/openstack/nova/tree/nova/objects/instance.py?id=d59dd36015dcf94cfa8eda64f480c43b18d63852#n834
[2] http://git.openstack.org/cgit/openstack/nova/tree/nova/objects/instance.py?id=d59dd36015dcf94cfa8eda64f480c43b18d63852#n1013

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/151823

[Davanum Srinivas (DIMS) (dims-v)]

Simon,

Can you please check if https://review.openstack.org/151823 fixes the problem for you?

thanks,
dims

[Simon Pasquier (simon-pasquier)]

@Dims
Looks good to me.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/151823
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d1c65d339a091751deb9f1e5b0a574af86655bec
Submitter: Jenkins
Branch: master

commit d1c65d339a091751deb9f1e5b0a574af86655bec
Author: Davanum Srinivas <email address hidden>
Date: Fri Jan 30 15:57:36 2015 -0800

    Ensure publisher_id is set correctly in notifications

    We need to pass the service parameter else the publisher_id is
    set to "None.node-1". There are many code paths that end up
    in get_noftifier, so let's just handle it there just like we
    default to CONF.host. Also the self.notifier in the
    resource_tracker was not being used, so get rid of it.

    Closes-Bug: #1416435
    Change-Id: I8838b961e49496cc85913a04bd99f9845ff308c3