servicegroup.API.leave() method is unused

Bug #1414513 reported by Jay Pipes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Ed Leafe

Bug Description

The nova.servicegroup.API.leave() method is not used by anything. It should be removed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/149923

Changed in nova:
assignee: Jay Pipes (jaypipes) → Ed Leafe (ed-leafe)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Jay Pipes (<email address hidden>) on branch: master
Review: https://review.openstack.org/149925

Changed in nova:
assignee: Ed Leafe (ed-leafe) → Jay Pipes (jaypipes)
Changed in nova:
assignee: Jay Pipes (jaypipes) → Ed Leafe (ed-leafe)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/149923
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7c387637614871fac460955c0ea3beb139ae168c
Submitter: Jenkins
Branch: master

commit 7c387637614871fac460955c0ea3beb139ae168c
Author: Jay Pipes <email address hidden>
Date: Sun Jan 25 16:56:47 2015 -0800

    Fix up join() and leave() methods of servicegroup

    The join() method was not documented properly, and the Zookeeper
    driver's implementation of the join() method returned a FakeLoopingCall
    object for no reason whatsoever (the other drivers just return None), so
    it's not necessary.

    The leave() method wasn't used anywhere at all, therefore this patch
    removes it entirely.

    Change-Id: Idbd95636dbebfb4f21a25d23625ee338c1ba863e
    Closes-bug: #1414513
    Closes-bug: #1414515

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.