force_config_drive gives inconsistent instance state

[Matthew Gilliard]

Default devstack install leaves

  force_config_drive = always

 in /etc/nova/nova.conf (slightly contradicting the docs: http://docs.openstack.org/user-guide/content/enable_config_drive.html which expects '.... = true')

An instance booted on this system does not have a config drive according to 'nova show', and does not get an entry in the config_drive column of the instances table. However the libvirt xml does show a config drive, and of course it's visible on the instance.

[Matthew Gilliard (matthew-gilliard-u)]

This is only evident when force_config_drive is used. If that is not set and an instance is booted with '--config_drive true' then the state is consistent.

[b.sudhakoushik (b-sudhakoushik)]

What is the version of nova being used to reproduce the issue ?

[Matthew Gilliard (matthew-gilliard-u)]

This was evident with the latest devstack at the time I logged the bug.

[Matthew Gilliard (matthew-gilliard-u)]

Still present with devstack 27f0339f8634df3f4b540e30df8667a42372482d, nova 8bcc72c81e8d6aadce84dcc931e41f5895e8b55f

[Gary Kotton (garyk)]

This is a documentation issue. The following values are support:
'always', 'True' or 'False'.
Please see - https://github.com/openstack/nova/blob/master/nova/virt/configdrive.py#L42
and
https://github.com/openstack/nova/blob/master/nova/virt/configdrive.py#L185
I have posted a fix to address the help text

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/156153

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/156186

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/156153
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c12a78b35dc910fa97df888960ef2b9a64557254
Submitter: Jenkins
Branch: master

commit c12a78b35dc910fa97df888960ef2b9a64557254
Author: Gary Kotton <email address hidden>
Date: Mon Feb 16 00:43:56 2015 -0800

    Config driver: update help text for force_config_drive

    The supported values are 'always', 'True' and 'False'. Update the
    help text to support this.

    DocImpact

    UpgradeImpact

    NOTE: the 'always' option will be deprecated in Liberty.

    Change-Id: Ib3de8402addb4657f4f6ede35792aab0b1498ff8
    Partial-bug: #1403889

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/156186
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c7d77624b73475c5ab67f27a641ec52cea324d8e
Submitter: Jenkins
Branch: master

commit c7d77624b73475c5ab67f27a641ec52cea324d8e
Author: Gary Kotton <email address hidden>
Date: Mon Feb 16 03:07:50 2015 -0800

    Compute: update config drive settings on instance

    In the case the config drive setting are overridden by either
    image properties or the configuration setting then these are updated
    on the instance to actually reflect the running VM configuration.

    The patch creates a common method for updating instance details
    after spawn.

    Change-Id: Ia5e36989a7b7543fa77c7c196919f8566e02d28a
    Closes-bug: #1403889