Power sync periodic task does $node_count API calls for Ironic driver

Bug #1399830 reported by Jim Rollenhagen
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Expired
Undecided
Unassigned

Bug Description

The power sync periodic task calls driver.get_info() for each instance in the database. This is typically fine; however in the Ironic driver, get_info() is an API call. We should bring this down to one API call.

Tags: ironic
Revision history for this message
Jim Rollenhagen (jim-rollenhagen) wrote :

s/instance_count/node_count/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/139767

Changed in nova:
assignee: nobody → Jim Rollenhagen (jim-rollenhagen)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/139767
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

Removing "In Progress" status and assignee as change is abandoned.

Changed in nova:
status: In Progress → Confirmed
assignee: Jim Rollenhagen (jim-rollenhagen) → nobody
Michael Still (mikal)
tags: added: ironic
Michael Still (mikal)
Changed in nova:
importance: Undecided → Low
Revision history for this message
Jim Rollenhagen (jim-rollenhagen) wrote :

I'll resurrect this

Revision history for this message
Michael Davies (mrda) wrote :

Well, since Jim wants to resurrect it, he can have it :)

Changed in nova:
assignee: nobody → Jim Rollenhagen (jim-rollenhagen)
Changed in nova:
assignee: Jim Rollenhagen (jim-rollenhagen) → nobody
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote : Cleanup EOL bug report

This is an automated cleanup. This bug report has been closed because it
is older than 18 months and there is no open code change to fix this.
After this time it is unlikely that the circumstances which lead to
the observed issue can be reproduced.

If you can reproduce the bug, please:
* reopen the bug report (set to status "New")
* AND add the detailed steps to reproduce the issue (if applicable)
* AND leave a comment "CONFIRMED FOR: <RELEASE_NAME>"
  Only still supported release names are valid (LIBERTY, MITAKA, OCATA, NEWTON).
  Valid example: CONFIRMED FOR: LIBERTY

Changed in nova:
importance: Low → Undecided
status: Confirmed → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers