Fix buggy tests that use REQUIRES_LOCKING=True

Bug #1398629 reported by Davanum Srinivas (DIMS)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Opinion
Medium
Sean Dague

Bug Description

from https://github.com/openstack/nova/blob/master/nova/test.py#L311

        # NOTE(sdague): because of the way we were using the lock
        # wrapper we eneded up with a lot of tests that started
        # relying on global external locking being set up for them. We
        # consider all of these to be *bugs*. Tests should not require
        # global external locking, or if they do, they should
        # explicitly set it up themselves.
        #
        # The following REQUIRES_LOCKING class parameter is provided
        # as a bridge to get us there. No new tests should be added
        # that require it, and existing classes and tests should be
        # fixed to not need it.

We need to fix the tests that use REQUIRES_LOCKING = True.

Tags: testing
Matt Riedemann (mriedem)
tags: added: testing
Changed in nova:
status: New → Confirmed
importance: Undecided → Medium
Joe Gordon (jogo)
Changed in nova:
assignee: nobody → Sean Dague (sdague)
Revision history for this message
Sean Dague (sdague) wrote :

A bug for this isn't really helping get this work done. This is just one of those non bug test cleanup efforts.

Changed in nova:
status: Confirmed → Opinion
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.