Legacy GroupAffinity and GroupAntiAffinity filters are broken

[Balazs Gibizer]

Both GroupAffinity and GroupAntiAffinity filters are broken. The scheduler does not respect the filters and schedules the servers against the policy.

Reproduction steps:
0) Spin up a single node devstack
1) Add GroupAntiAffinityFilter to scheduler_default_filters in nova.conf and restart the nova services
2) Boot multiple server with the following command
nova boot --image cirros-0.3.2-x86_64-uec --flavor 42 --hint group=foo server-1

Expected behaviour:
The second and any further boot should fail with NoValidHostFound exception as anti-affinity policy cannot be fulfilled.

Actual behaviour:
Any number of servers are booted to the same compute node

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/135933

[OpenStack Infra (hudson-openstack)]

Change abandoned by Balazs Gibizer (<email address hidden>) on branch: master
Review: https://review.openstack.org/135933
Reason: Abandon in favour of https://review.openstack.org/#/c/134068/

[Balazs Gibizer (balazs-gibizer)]

GroupAffinity and GroupAntiAffinity is deprecated and being removed in Kilo. See https://review.openstack.org/#/c/134068/

[Balazs Gibizer (balazs-gibizer)]

The problem is visible on stable/juno so I will propose the fix for stable/juno.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/136396

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/136396
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=361ece2b7a294e9afb7d64232af888b311cf2abb
Submitter: Jenkins
Branch: stable/juno

commit 361ece2b7a294e9afb7d64232af888b311cf2abb
Author: Balazs Gibizer <email address hidden>
Date: Fri Nov 21 16:31:44 2014 +0100

    Add legacy to the possible server group policies

    To make the legacy GroupAffinityFilter and GroupAntiAffinityFilter works
    the scheduler code needs to understand the 'legacy' policy in the server
    group.
    This is a stable only fix as in master the related code path has been removed
    after deprecation.

    Closes-Bug: #1394551
    Change-Id: Ib46e035fa2687074ca05a902aa6321c507d01abc

[Balazs Gibizer (balazs-gibizer)]

Same problem is visible on stable/icehouse. I will backport the juno patch to stable/icehouse

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/139609

[OpenStack Infra (hudson-openstack)]

Change abandoned by Balazs Gibizer (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/139609
Reason: This is not a critical bug and Icehouse branch should only receive critical bug fixes.

[Davanum Srinivas (DIMS) (dims-v)]

looks like this is fixed

[Davanum Srinivas (DIMS) (dims-v)]

in juno and invalid in kilo