REBOOTING_HARD not in expected_task_state

[Jesse J. Cook]

On hard reboot, the task state is set to REBOOTING_HARD (https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2213). This can be verified by rebooting twice in a row: {"conflictingRequest": {"message": "Cannot 'reboot' while instance is in task_state rebooting_hard", "code": 409}}. However, REBOOTING_HARD is not in expected_task_state (https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2215). Shouldn't it be?

[Jesse J. Cook (jesse-j-cook)]

Discovered here: https://review.openstack.org/#/c/117859/1/nova/compute/api.py

[Christopher Yeoh (cyeoh-0)]

So we don't allow a hard reboot whilst hard rebooting, but there is a lot of cleanup that we could do here.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/127427

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/127427
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Davanum Srinivas (DIMS) (dims-v)]

Fix proposed again.

[Park (jianlonghei)]

https://bugs.launchpad.net/nova/+bug/1376384
does this bug fix the bug 1379425?

I noticed that 1376384 added REBOOTING_HARD and made some other things update.

[Sean Dague (sdague)]

This seems stalled, taking out of in progress

[Diana Clarke (diana-clarke)]

Indeed, I think this bug can be closed (see comment #6, thanks Park).

I could be wrong, but I think this unit test shows that this case has been fixed (doing a HARD_REBOOT when the current state is REBOOTING_HARD).

https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/test_server_actions.py#L261

Can someone please confirm & close this bug? Thanks!

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/127427
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d60497e9f9ce8a6fc54a457eaa2cdab2a817ac90
Submitter: Jenkins
Branch: master

commit d60497e9f9ce8a6fc54a457eaa2cdab2a817ac90
Author: Chris Yeoh <email address hidden>
Date: Fri Oct 10 16:44:52 2014 +1030

    Cleanup of compute api reboot method

    The interaction between the check_instance_state decorator for
    the compute api reboot method and the extra checking done within
    the method for task states was confusing and in some cases
    contradictory.

    Also several task states allowed by the decorator were implicitly
    rejected because they were not listed in the expected task_states for
    the instance save call. This too is fixed.

    Change-Id: Iba24f2ed9d2d3161318b4b1fc55c0e97d7aed1c6
    Closes-Bug: 1379425

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/nova 13.0.0.0b2 development milestone.