VMWare: should use ShutDownGuest to do grace OS shutdown and then force power off if timeout passed

Bug #1377781 reported by zhu zhu on 2014-10-06
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Low
David Rabel

Bug Description

With currently vmware driver. the power_off will explicitly calls
PowerOffVM_Task.

In this case, If a virtual machine is writing to disk when it receives a Power Off command, data corruption may occur.

Actually in SDK, there is another method
ShutdownGuest which will issues a command to the guest operating system asking it to perform a clean shutdown of all services.

So it is suggest to use ShutdownGuest first and wait for some interval, if the power state is still up, make a force shutdown.

zhu zhu (zhuzhubj) on 2014-10-06
tags: added: vmware
Changed in nova:
importance: Undecided → Low
status: New → Confirmed

Fix proposed to branch: master
Review: https://review.openstack.org/126833

Changed in nova:
assignee: nobody → zhu zhu (zhuzhubj)
status: Confirmed → In Progress

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/126833
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Removing "In Progress" status and assignee as change is abandoned.

Changed in nova:
status: In Progress → Confirmed
assignee: zhu zhu (zhuzhubj) → nobody
Changed in nova:
assignee: nobody → Thomas Kaergel (thomas-kaergel)
Changed in nova:
assignee: Thomas Kaergel (thomas-kaergel) → nobody

Fix proposed to branch: master
Review: https://review.openstack.org/288329

Changed in nova:
assignee: nobody → Thomas Kaergel (thomas-kaergel)
status: Confirmed → In Progress

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/288329
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

Sean Dague (sdague) wrote :

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

Changed in nova:
status: In Progress → Confirmed
assignee: Thomas Kaergel (thomas-kaergel) → nobody
Changed in nova:
assignee: nobody → Thomas Kaergel (thomas-kaergel)

Fix proposed to branch: master
Review: https://review.openstack.org/494169

Changed in nova:
assignee: Thomas Kaergel (thomas-kaergel) → David Rabel (rabel-b1)
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/494169
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=24aaf8752db25e1e71f4a14502f0ea3b1ab1b7de
Submitter: Zuul
Branch: master

commit 24aaf8752db25e1e71f4a14502f0ea3b1ab1b7de
Author: Thomas Kaergel <email address hidden>
Date: Fri Mar 4 10:25:45 2016 +0100

    VMware: add support for graceful shutdown of instances

    Change-Id: I40643e9d358be89c87a0311b1c1fd7718ec75361
    Closes-Bug: #1377781
    Co-Authored-By: David Rabel <email address hidden>

Changed in nova:
status: In Progress → Fix Released

This issue was fixed in the openstack/nova 17.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers