obj_make_compatible is wrong

Bug #1373535 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Vish Ishaya

Bug Description

Commit 7cdfdccf1bb936d559bd3e247094a817bb3c03f4 attempted to make the obj_make_compatible calls consistent, but it actually changed them the wrong way.

Change https://review.openstack.org/#/c/121663/ addresses the bug but is sitting on top of a change that might be too risky at this point for juno-rc1, so this should be a separate fix.

Matt Riedemann (mriedem)
Changed in nova:
status: New → Triaged
importance: Undecided → High
Boden R (boden)
Changed in nova:
assignee: nobody → Boden R (boden)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/124082

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by boden (<email address hidden>) on branch: master
Review: https://review.openstack.org/124082
Reason: abandon in light of: https://review.openstack.org/#/c/121663/

Changed in nova:
assignee: Boden R (boden) → Vish Ishaya (vishvananda)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/121663
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=279b6e98bc72c906ac2c3f8665a1acdc99b30833
Submitter: Jenkins
Branch: master

commit 279b6e98bc72c906ac2c3f8665a1acdc99b30833
Author: Vishvananda Ishaya <email address hidden>
Date: Sat Sep 13 11:56:57 2014 -0700

    Undo changes to obj_make_compatible

    Commit 7cdfdccf1bb936d559bd3e247094a817bb3c03f4 attempted to make
    the obj_make_compatible calls consistent, but it actually changed
    them the wrong way. This fixes them to unwrap nova_object.data
    and updates the test that was testing the reverse.

    Change-Id: I1a5db4e9817390ba3c2423d33387f780c890de64
    Closes-Bug: #1373535

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.