TypeError: consume_from_instance() takes exactly 2 arguments

[Dan Prince]

As of today we are seeing the following scheduler errors when trying to schedule Ironic instances:

Sep 13 16:42:48 ubuntu nova-scheduler: a/local/lib/python2.7/site-packages/nova/scheduler/filter_scheduler.py", line 147, in select_destinations\n filter_properties)\n', ' File "/opt/stack/venvs/nova/local/lib/python2.7/site-packages/nova/scheduler/filter_scheduler.py", line 300, in _schedule\n chosen_host.obj.consume_from_instance(context, instance_properties)\n', 'TypeError: consume_from_instance() takes exactly 2 arguments (3 given)\n']

[Dan Prince (dan-prince)]

This Nova commit looks to be the root cause of the issue:

http://git.openstack.org/cgit/openstack/nova/commit/nova?id=2bc74e66d90b6fae3c5ca8f79f99e75169da644f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/121397

[Dan Prince (dan-prince)]

Also cherry picking it for TripleO CI here:

https://review.openstack.org/#/c/121385/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/121397
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e65bf1febb66cb2771834f4bbb11c2e61579ad7d
Submitter: Jenkins
Branch: master

commit e65bf1febb66cb2771834f4bbb11c2e61579ad7d
Author: Dan Prince <email address hidden>
Date: Sat Sep 13 22:03:29 2014 -0400

    Correct baremetal/ironic consume_from_instance...

    In 2bc74e66d90b6fae3c5ca8f79f99e75169da644f we recently changed
    the HostState.consume_from_instance method parameters to include a
    context. This patch updates the relevate baremetal/ironic host state
    classes to do likewise.

    This fixes a critical TypeError that occurs when trying to use
    Ironic or Nova Baremetal otherwise.

    Change-Id: I46eebce19603cb4c4a934b1647ff6433d75799ad
    Closes-bug: #1369151

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/121609

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/121610

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/121609
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b4ce9490b9c3c8d2e37a49ca314654760b349367
Submitter: Jenkins
Branch: master

commit b4ce9490b9c3c8d2e37a49ca314654760b349367
Author: Daniel P. Berrange <email address hidden>
Date: Mon Sep 15 16:31:26 2014 +0100

    virt: move assertPublicAPISignatures into base test class

    The nova/tests/virt/test_driver.py has a useful method for
    validating subclass APIs vs the base class contract. This
    can be used in many places in Nova, so move it into the
    base TestCase class for broader reuse.

    Related-bug: #1369151
    Change-Id: Ib49e888aae31fb0d47c1d11f35648e9cb2595c75

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/121610
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5e8f2a78c02d4b8499375d837e53215a1c80a47e
Submitter: Jenkins
Branch: master

commit 5e8f2a78c02d4b8499375d837e53215a1c80a47e
Author: Daniel P. Berrange <email address hidden>
Date: Mon Sep 15 16:40:12 2014 +0100

    ironic/baremetal: add validation of host manager/state APIs

    Add tests to ensure the ironic & baremetal HostManager and
    HostState sub-classes comply with the API contract defined
    in their parent class.

    Related-bug: #1369151
    Change-Id: Ic2cf17c59c06fe2222db4bc5ea0e68f87c4399e9