Wrong status code in @wsgi.response decorator in server's `confirmResize` action

Bug #1368597 reported by Ghanshyam Mann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Ghanshyam Mann

Bug Description

In server`s action `confirmResize` status code in @wsgi.response decorator is set as 202 but this is overridden/ignored by return statement (return exc.HTTPNoContent()) which return 204 status code - https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L1080

This is very confusing and we should have expected status code in @wsgi.response decorator as consistence with other APIs.

There is no change required in API return status code but in code it should be fixed to avoid the confusion.

Changed in nova:
assignee: nobody → Ghanshyam Mann (ghanshyammann)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/121025

Changed in nova:
status: New → In Progress
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/121025
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=21baedfc3185111589535cdc24fff83603a5e3fc
Submitter: Jenkins
Branch: master

commit 21baedfc3185111589535cdc24fff83603a5e3fc
Author: Ghanshyam <email address hidden>
Date: Fri Sep 12 17:01:49 2014 +0900

    Fix `confirmResize` action status code in V2

    In server`s action `confirmResize` status code in @wsgi.response
    decorator is set as 202 but this is overridden/ignored by return
    statement (return exc.HTTPNoContent()) which return 204 status code.

    This is very confusing and we should have expected status code in
    @wsgi.response decorator as consistence with other APIs.

    NOTE- There is no change in API return status code. API returns the
    same 204 return code as previously.

    Change-Id: Id8033fb8880306babebc14b319bce5b3b8798774
    Closes-Bug: #1368597

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.