Improve ironic driver logging configurability

Bug #1365230 reported by Michael Davies
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Daniel Berrange

Bug Description

As part of review https://review.openstack.org/#/c/111425/19/nova/virt/ironic/driver.py it was suggested that logging configurability be addressed in the ironic driver.

A number of different viewpoints exist regarding whether the ironic driver should be independently configurable; and whether there should be a way to turn down the "chatyness" of the driver for operator sanity.

This is raised a bug so that the right solution for nova can be considered and implemented independently.

Changed in nova:
status: New → Confirmed
importance: Undecided → Medium
aeva black (tenbrae)
Changed in nova:
importance: Medium → Low
tags: added: ironic
Revision history for this message
Michael Still (mikal) wrote :

The python logging framework already allows configuring log levels on a per module basis. Doesn't that cover our needs here?

Revision history for this message
Jim Rollenhagen (jim-rollenhagen) wrote :

Yes, we should go back and deprecate/remove this option in favor of the logging framework.

tags: added: low-hanging-fruit
Changed in nova:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

@Rodolfo: Are you still working on this? It's been >4 weeks until you set yourself as assignee but I cannot find a patch for that.

Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

Sorry, I was working with ironic with no time for this.

My apologies.

Changed in nova:
assignee: Rodolfo Alonso (rodolfo-alonso-hernandez) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/312006

Changed in nova:
assignee: nobody → Markus Zoeller (markus_z) (mzoeller)
status: Confirmed → In Progress
Changed in nova:
assignee: Markus Zoeller (markus_z) (mzoeller) → Daniel Berrange (berrange)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/312006
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a924b1db46149d2928731f59afb7fef18deed54d
Submitter: Jenkins
Branch: master

commit a924b1db46149d2928731f59afb7fef18deed54d
Author: Markus Zoeller <email address hidden>
Date: Tue May 3 11:35:47 2016 +0200

    config: remove deprecated ironic.client_log_level

    The config option "client_log_level" of the "ironic" section was
    deprecated with commit d6baa2ae4d7f18dc2e4845af25c21b95767f46ef since
    the Kilo release and this change removes this option.

    Closes-Bug: 1365230
    Change-Id: I605d4ca5b3924ecf013cbf7e228e713b864d7aa4

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/nova 14.0.0.0b1

This issue was fixed in the openstack/nova 14.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers