Error retries in _allocate_network

Bug #1363326 reported by AiQingxing
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
zhangtralon

Bug Description

In /nova/compute/manager.py/def _allocate_network_async,line 1559.

attempts = retries > 1 and retries + 1 or 1
retry_time = 1
for attempt in range(1, attempts + 1):

Variable attempts wants to determine the retry times of allocate network,but it made a small mistake.
See the Simulation results below:
retries=0,attempts=1
retries=1,attempts=1
retries=2,attempts=3
When retries=1, attempts=1 ,It actually does not retry.

Tags: network
AiQingxing (aiqingxing)
Changed in nova:
assignee: nobody → AiQingxing (aiqingxing)
Tracy Jones (tjones-i)
tags: added: network
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/119270

Changed in nova:
assignee: AiQingxing (aiqingxing) → zhangtralon (zhangchunlong1)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/119270
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4ba7ee4c1bb89b2fa48c2091df1d7f0bcf10ee02
Submitter: Jenkins
Branch: master

commit 4ba7ee4c1bb89b2fa48c2091df1d7f0bcf10ee02
Author: <email address hidden> <email address hidden>
Date: Thu Sep 18 14:44:28 2014 +0800

    the value of retries is error in _allocate_network

    the variable 'retries' stands for the times retried by allocate
    network ,but it makes a mistake

    Change-Id: Ia4c046641619f619f8bf6205f841b3a332d31260
    Closes-Bug: #1363326

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.