param check for backup rotatetype is needed

Bug #1361490 reported by jichenjc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
jichenjc

Bug Description

jichen@cloudcontroller:~$ nova backup jitest1 jiback1 eeee 2
jichen@cloudcontroller:~$ nova list
+--------------------------------------+---------+--------+------------+-------------+--------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+---------+--------+------------+-------------+--------------------+
| cb7c6742-7b7a-44de-ad5a-8570ee520f9e | jitest1 | ACTIVE | - | Running | private=10.0.0.2 |
| 702d1d2b-f72d-4759-8f13-9ffbcc0ca934 | jitest3 | PAUSED | - | Paused | private=10.0.0.200 |
+--------------------------------------+---------+--------+------------+-------------+--------------------+

however , after I proposed solution to change v2, we got suggestion that this value is only used in glance so we should delegate it to glance to check whether it's proper or not
so the final solution is to let it be and ignore the error list above

currently v2.1 (v3) API has validation for it. the proposed patch will remove it

jichenjc (jichenjc)
Changed in nova:
assignee: nobody → jichenjc (jichenjc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/116792

Changed in nova:
status: New → In Progress
jichenjc (jichenjc)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/116792
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d42314b323aa0f8c764d72a5ebebc0e7d5ac88f3
Submitter: Jenkins
Branch: master

commit d42314b323aa0f8c764d72a5ebebc0e7d5ac88f3
Author: jichenjc <email address hidden>
Date: Sat Aug 23 09:04:43 2014 +0800

    Remove param check for backup type on v2.1 API

    The backup type is only used by glance, so nova check it make
    no sense; currently we have daily and weekly as only valid param
    but someone may add 'monthly' as param. nova should allow it
    and delegate the error. This patch removes check on v2.1 API.

    Change-Id: I59bbc0f589c8c280eb8cd87aa279898fffaeab7a
    Closes-Bug: #1361490

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.