nova.tests.network.test_manager.AllocateTestCase should use mock

[Jay Pipes]

Unit tests should not need to start services. Instead, they should simply mock out the specific calls out of the unit of code that is being tested.

nova.tests.network.test_manager.AllocateTestCase calls self.start_service() for the conductor, network, and compute service, and it does so unnecessarily. This results in long test run times and tests that are affected by side effects.

Remove the calls to self.start_service() and replace with proper use of mock.

[Davanum Srinivas (DIMS) (dims-v)]

Vineet, i don't see any reviews in progress, so setting this back to confirmed. please add a link to the review if/when you start one.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/185860

[OpenStack Infra (hudson-openstack)]

Change abandoned by Zhenyu Zheng (<email address hidden>) on branch: master
Review: https://review.openstack.org/185860

[Sameer Adhikari (tri2sing)]

First attempt at contributing code. Please help in anyway you see fit.

[Andrea Rosa (andrea-rosa-m)]

@Aniruddha Singh Gautam are you still working on this bug?

[bharaththiruveedula (bharath-ves)]

@Aniruddha, May be you are occupied task and no progress on this bug, I would like to work on this bug. So I assigned this to myself. Apologies for the same.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/255876

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/255876
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f92264dab59e53fa27d068bbd0f9fa4927867e14
Submitter: Jenkins
Branch: master

commit f92264dab59e53fa27d068bbd0f9fa4927867e14
Author: Bharath Thiruveedula <email address hidden>
Date: Thu Dec 10 18:42:37 2015 +0530

    Remove start_service calls from the test case

    Currently in nova.tests.unit.network.test_manager.AllocateTestCase
    start_service have been used to start nova compute and network services.
    But these calls takes most of the time while running the test cases. In
    this patch start_service method calls are removed to make test cases run
    fast.

    Change-Id: I908dc6007d66c482254f07c035e948daff2319f1
    Closes-Bug: #1357751

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/nova 13.0.0.0b2 development milestone.