VMware: unable to access VNC console of rescue VM

[Gary Kotton]

When doing a rescue VM the user is unable to access the VNC console of that VM
In addition the state of the rescue VM is also 'SHUTDOWN'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/113908

[Tracy Jones (tjones-i)]

as this only affects 1 hypervisor by definition it cannot be critical

[Michael Still (mikal)]

Is anyone working on this bug? We might need to drop if from rc1 if there isn't a fix proposed soon.

[Gary Kotton (garyk)]

review is at https://review.openstack.org/113908

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/113908
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cd1765459a24e52e1b933c8e05517fed75ac9d41
Submitter: Jenkins
Branch: master

commit cd1765459a24e52e1b933c8e05517fed75ac9d41
Author: Gary Kotton <email address hidden>
Date: Wed Aug 13 07:11:55 2014 -0700

    VMware: fix VM rescue problem with VNC console

    The user was unable to access the VNC console after a VM was rescued.

    This is solved by refactoring the rescue/unrescue operations. We
    no longer spawn a new VM on rescue but attach the original image and
    boot from it. On unrescue detach the original (rescue) image.

    Co-authored-by: Radoslav Gerganov <email address hidden>

    UpgradeImpact

    Prior to this patch a rescue operation would create a new VM and the
    rescue would take place on the new VM. This is prone to an endless
    amount of problems. Some of the issues found are:
     - unable to access the VNC console of a rescued instance
     - unstable to suspend or resume a rescued instance
     - rescue with ephemeral disks does not work
    This patch now uses an inplace rescue on the same
    VM. It is suggested that when upgrading to the latest version to ensure
    that users are aware that a rescue during the upgrade may be problematic.
    It is suggested that in the upgrade window that the admin prevent instances
    being rescued and give sufficient notice to users.

    Change-Id: I3218e7edfe0f71626b2930c39dea0fba4d2e69ca
    Closes-bug: #1356389