VMware: ESX deprecation break VC driver

Bug #1355875 reported by Gary Kotton
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Critical
Davanum Srinivas (DIMS)

Bug Description

The ESX dprecation https://github.com/openstack/nova/commit/1deb31f85a8f5d1e261b2cf1eddc537a5da7f60b break devstack

2014-08-12 07:53:45.453 ERROR nova.openstack.common.threadgroup [-]
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup Traceback (most recent call last):
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/openstack/common/threadgroup.py", line 125, in wait
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup x.wait()
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/openstack/common/threadgroup.py", line 47, in wait
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup return self.thread.wait()
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup File "/usr/lib/python2.7/dist-packages/eventlet/greenthread.py", line 168, in wait
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup return self._exit_event.wait()
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup File "/usr/lib/python2.7/dist-packages/eventlet/event.py", line 116, in wait
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup return hubs.get_hub().switch()
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup File "/usr/lib/python2.7/dist-packages/eventlet/hubs/hub.py", line 187, in switch
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup return self.greenlet.switch()
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup File "/usr/lib/python2.7/dist-packages/eventlet/greenthread.py", line 194, in main
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup result = function(*args, **kwargs)
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/openstack/common/service.py", line 490, in run_service
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup service.start()
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/service.py", line 164, in start
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup self.manager.init_host()
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/compute/manager.py", line 1058, in init_host
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup self.driver.init_host(host=self.host)
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/virt/driver.py", line 150, in init_host
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup raise NotImplementedError()
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup NotImplementedError
2014-08-12 07:53:45.453 TRACE nova.openstack.common.threadgroup
nicira@Ubuntu1404Server:/opt/stack/nova$

Gary Kotton (garyk)
Changed in nova:
importance: Undecided → Critical
assignee: nobody → Gary Kotton (garyk)
milestone: none → juno-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/113548

Changed in nova:
status: New → In Progress
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

Gary, please take a peek at Tesshu's patch - https://launchpadlibrarian.net/182102169/novaVMwareVCDriver.patch from https://bugs.launchpad.net/nova/+bug/1355885 it has an additional cleanup_host as well

Changed in nova:
assignee: Gary Kotton (garyk) → Davanum Srinivas (DIMS) (dims-v)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/113548
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d8a18d72e046efa2785b1351a00476adb9343b57
Submitter: Jenkins
Branch: master

commit d8a18d72e046efa2785b1351a00476adb9343b57
Author: Gary Kotton <email address hidden>
Date: Tue Aug 12 07:58:54 2014 -0700

    VMware: fix crash when VC driver boots

    Commit 1deb31f85a8f5d1e261b2cf1eddc537a5da7f60b caused the driver to break.
    This adds the missing method.

    Change-Id: Iaf7e33a868724efdcb13fdd9ba1c74b92d2e6210
    Closes-bug: #1355875

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Reviewed: https://review.openstack.org/113654
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=49d4defee6b5182eca31431ae8273d3a523f3e61
Submitter: Jenkins
Branch: master

commit 49d4defee6b5182eca31431ae8273d3a523f3e61
Author: Davanum Srinivas <email address hidden>
Date: Tue Aug 12 17:13:59 2014 -0400

    VMware: revert deletion of cleanup_host

    Commit 1deb31f85a8f5d1e261b2cf1eddc537a5da7f60b removes cleanup_host
    by mistake. This adds the missing method back.

    Related-Bug: #1355875

    Change-Id: If695bf00613fe389af91f453dbc8191698d95a94

Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.