Ironic virt driver should define a minimum ironicclient version

[Jim Rollenhagen]

The virt driver may need to rely on bug fixes or features in a certain version of python-ironicclient. At import time, we should also check which version of ironicclient is installed, and bail if it's too old.

[Prabhjyot Singh Sodhi (psd0)]

Hi!
I am new to open source and would love to contribute to this bug!
I have setup devstack.
any pointers?

[Ramakrishnan G (rameshg87) (rameshg87)]

Prabhjyot Singh Sodhi, welcome. Below is my thought.

We can mention the minimum required version of python-ironicclient within nova virt driver and check it at the time of starting the driver.

This is what another virt driver libvirt also seems to do.
https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L341
https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L534

[Ajay Pandey (osdiaj)]

Hi Ramakrishnan,

Thanks for the suggestion above.
I'm new too.

Just a question :
What would be minimum version for ironic client......1?
That's what ironicclient.client.get_client 's docstring seems to suggest.

Thanks,
Ajay

[Michael Davies (mrda)]

This is related to https://bugs.launchpad.net/nova/+bug/1459874 - so the people involved should talk :-)

[Jim Rollenhagen (jim-rollenhagen)]

While this is similar to the microversion stuff, it's actually a different thing. We want to be able to specify a minimum version of the ironicclient code that is running. However, as nova won't include ironicclient in requirements.txt, we can't ensure via pip that the right thing is installed.

At driver initialization time, we should check the version of ironicclient that is imported, and make sure it's >= some version that we hardcode. We'll bump that as necessary when a newer client is needed for some feature. We can start with the version currently in global-requirements.txt.

[Markus Zoeller (markus_z) (mzoeller)]

The age and number of assignee changes suggest that this isn't really
a low-hanging-fruit. I'm removing the tag to not confuse new folks who
are searching for that tag.

[Markus Zoeller (markus_z) (mzoeller)]

This is an automated cleanup. This bug report has been closed because it
is older than 18 months and there is no open code change to fix this.
After this time it is unlikely that the circumstances which lead to
the observed issue can be reproduced.

If you can reproduce the bug, please:
* reopen the bug report (set to status "New")
* AND add the detailed steps to reproduce the issue (if applicable)
* AND leave a comment "CONFIRMED FOR: <RELEASE_NAME>"
  Only still supported release names are valid (LIBERTY, MITAKA, OCATA, NEWTON).
  Valid example: CONFIRMED FOR: LIBERTY