Ironic virt driver should define a minimum ironicclient version

Bug #1355820 reported by Jim Rollenhagen
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Invalid
Low
Unassigned
OpenStack Compute (nova)
Expired
Undecided
Unassigned

Bug Description

The virt driver may need to rely on bug fixes or features in a certain version of python-ironicclient. At import time, we should also check which version of ironicclient is installed, and bail if it's too old.

Dmitry Tantsur (divius)
tags: added: nova-driver
Changed in ironic:
status: New → Triaged
importance: Undecided → Low
Dmitry Tantsur (divius)
summary: - Virt driver should define a minimum ironicclient version
+ Ironic virt driver should define a minimum ironicclient version
tags: added: ironic
Changed in ironic:
status: Triaged → Invalid
Sean Dague (sdague)
Changed in nova:
status: New → Confirmed
importance: Undecided → Low
status: Confirmed → Triaged
tags: added: low-hanging-fruit
Revision history for this message
Prabhjyot Singh Sodhi (psd0) wrote :

Hi!
I am new to open source and would love to contribute to this bug!
I have setup devstack.
any pointers?

Revision history for this message
Ramakrishnan G (rameshg87) (rameshg87) wrote :

Prabhjyot Singh Sodhi, welcome. Below is my thought.

We can mention the minimum required version of python-ironicclient within nova virt driver and check it at the time of starting the driver.

This is what another virt driver libvirt also seems to do.
https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L341
https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L534

Revision history for this message
Ajay Pandey (osdiaj) wrote :

Hi Ramakrishnan,

Thanks for the suggestion above.
I'm new too.

Just a question :
What would be minimum version for ironic client......1?
That's what ironicclient.client.get_client 's docstring seems to suggest.

Thanks,
Ajay

Sean Dague (sdague)
Changed in nova:
status: Triaged → Confirmed
Changed in nova:
assignee: nobody → Sreeram Vancheeswaran (svancheeswaran)
Revision history for this message
Michael Davies (mrda) wrote :

This is related to https://bugs.launchpad.net/nova/+bug/1459874 - so the people involved should talk :-)

Changed in nova:
assignee: Sreeram Vancheeswaran (svancheeswaran) → nobody
Revision history for this message
Jim Rollenhagen (jim-rollenhagen) wrote :

While this is similar to the microversion stuff, it's actually a different thing. We want to be able to specify a minimum version of the ironicclient code that is running. However, as nova won't include ironicclient in requirements.txt, we can't ensure via pip that the right thing is installed.

At driver initialization time, we should check the version of ironicclient that is imported, and make sure it's >= some version that we hardcode. We'll bump that as necessary when a newer client is needed for some feature. We can start with the version currently in global-requirements.txt.

Michael Davies (mrda)
Changed in nova:
assignee: nobody → Michael Davies (mrda)
Michael Davies (mrda)
Changed in nova:
assignee: Michael Davies (mrda) → nobody
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

The age and number of assignee changes suggest that this isn't really
a low-hanging-fruit. I'm removing the tag to not confuse new folks who
are searching for that tag.

tags: removed: low-hanging-fruit
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote : Cleanup EOL bug report

This is an automated cleanup. This bug report has been closed because it
is older than 18 months and there is no open code change to fix this.
After this time it is unlikely that the circumstances which lead to
the observed issue can be reproduced.

If you can reproduce the bug, please:
* reopen the bug report (set to status "New")
* AND add the detailed steps to reproduce the issue (if applicable)
* AND leave a comment "CONFIRMED FOR: <RELEASE_NAME>"
  Only still supported release names are valid (LIBERTY, MITAKA, OCATA, NEWTON).
  Valid example: CONFIRMED FOR: LIBERTY

Changed in nova:
importance: Low → Undecided
status: Confirmed → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers