Delete and re-add of same node to compute_nodes table is broken

Bug #1352510 reported by Chris Behrens
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Ed Leafe

Bug Description

When a compute node is deleted (or marked deleted) in the DB and another compute node is re-added with the same name, things break.

This is because the resource tracker caches the compute node object/dict and uses the 'id' to update the record. When this happens, rt.update_available_resources will raise a ComputeHostNotFound. This ends up short-circuiting the full run of the update_available_resource() periodic task.

This mostly applies when using a virt driver where a nova-compute manages more than 1 "hypervisor".

Tags: compute ironic
Chris Behrens (cbehrens)
Changed in nova:
status: New → In Progress
assignee: nobody → Chris Behrens (cbehrens)
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/111837

Matt Riedemann (mriedem)
tags: added: compute ironic
Changed in nova:
assignee: Chris Behrens (cbehrens) → jichenjc (jichenjc)
Changed in nova:
assignee: jichenjc (jichenjc) → Ed Leafe (ed-leafe)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Joe Gordon (<email address hidden>) on branch: master
Review: https://review.openstack.org/111837

Revision history for this message
Jim Rollenhagen (jim-rollenhagen) wrote :

This seems like it's probably fixed by https://review.openstack.org/#/c/111838 but I have yet to verify.

Revision history for this message
Jim Rollenhagen (jim-rollenhagen) wrote :

15:15:57 edleafe | jroll: ok, got to look at that bug, and yeah, it should have closed it, but I forgot to put Closes-bug: in the commit message

And I agree it appears to fix it.

Revision history for this message
Jim Rollenhagen (jim-rollenhagen) wrote :

15:15:57 edleafe | jroll: ok, got to look at that bug, and yeah, it should have closed it, but I forgot to put Closes-bug: in the commit message

And I agree it appears to fix it.

This was released with Liberty-1

Changed in nova:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers