Move _is_mapping logic to more central place

Bug #1351810 reported by Thang Pham
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Thang Pham

Bug Description

This bug is a follow-up to Nikola Dipanov's comment in https://review.openstack.org/#/c/109834/2/nova/compute/manager.py.
The logic to identify volumes is currently a nested function in _default_block_device_names, named _is_mapping. It should be moved to a more general place so others could utilize it.

Tags: volumes
Thang Pham (thang-pham)
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/114799

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/114799
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=062b1f8c0f6ba09ab6764ea512c3615fc93aaf08
Submitter: Jenkins
Branch: master

commit 062b1f8c0f6ba09ab6764ea512c3615fc93aaf08
Author: Thang Pham <email address hidden>
Date: Sat Aug 16 21:40:29 2014 -0400

    Move _is_mapping to more central location

    The logic to identify volumes is currently a nested function
    in _default_block_device_names, named _is_mapping. It should
    be moved to a more general location so others could utilize it
    and allow it to be properly unit tested. The following patch
    moves _is_mapping to nova/virt/block_device.py and renames it
    to is_block_device_mapping.

    Change-Id: I560abc4b57ca5bd195282af7cd1ab9bbf7600b67
    Closes-Bug: #1351810

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.